Skip to content

AsyncHook MemoryLeak fixes #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

AsyncHook MemoryLeak fixes #60

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abcf5a7
Fixing memory leak: disable asyn_hook, when it's namespace destroyed
alexgarbarev Jun 2, 2020
d0d63b9
zerofying _context when namespace destoryed
alexgarbarev Jun 3, 2020
b65ea3b
typo fixes in comment
alexgarbarev Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ function Namespace(name) {
this.id = null;
this._contexts = new Map();
this._indent = 0;
this._hook = null;
}

Namespace.prototype.set = function set(key, value) {
Expand Down Expand Up @@ -427,6 +428,8 @@ function createNamespace(name) {

hook.enable();

namespace._hook = hook;

process.namespaces[name] = namespace;
return namespace;
}
Expand All @@ -437,6 +440,15 @@ function destroyNamespace(name) {
assert.ok(namespace, 'can\'t delete nonexistent namespace! "' + name + '"');
assert.ok(namespace.id, 'don\'t assign to process.namespaces directly! ' + util.inspect(namespace));

namespace._hook.disable();

/*
* Zeroing _contexts as heaviest part of Namespace
* In case our namespace is retained mistakenly, so
* at least we are releasing heaviest part
*/
namespace._contexts = null;
Copy link

@ankon ankon Jun 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos, and this shouldn't be JSDoc block. Maybe:

/*
 * Zeroing _contexts as heaviest part of Namespace
 * In case our namespace is retained mistakenly, so
 * at least we are releasing heaviest part
 */

Copy link
Author

@alexgarbarev alexgarbarev Jun 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree with these changes. Thanks for suggestions.


process.namespaces[name] = null;
}

Expand Down