Skip to content

Marten docs: fix stale IRevisioned int->long widening reverted by #4533#4534

Merged
jeremydmiller merged 2 commits into
masterfrom
docs/4533-fix-stale-irevisioned-widening
May 20, 2026
Merged

Marten docs: fix stale IRevisioned int->long widening reverted by #4533#4534
jeremydmiller merged 2 commits into
masterfrom
docs/4533-fix-stale-irevisioned-widening

Conversation

@jeremydmiller
Copy link
Copy Markdown
Member

Summary

An early Marten 9 alpha widened IRevisioned.Version from int to long (#3733 / #4377). PR #4533 reverted that before rc.1IRevisioned.Version stays int (Marten 8-compatible), and a new ILongVersioned (long) was added for MultiStreamProjection documents whose Version is the global event sequence number. Two docs never got the memo. This is a docs-only fix.

Two fixes

  1. docs/migration-guide.md — the "Numeric document revisions widened from int to long" section was entirely stale (it told users to widen every IRevisioned.Version to long). Rewritten to:

  2. docs/documents/concurrency.md — the embedded sample_versioned_reservation snippet still showed long Version even though its source RevisionedDocuments.cs was already int. Regenerated via mdsnippets (not hand-edited). Unrelated incidental snippet drift in hostbuilder.md / retries.md was reverted to keep this PR focused.

Test plan

  • Docs-only — no src/ production changes.
  • markdownlint (CI args) clean on both files.
  • cspell (CI args, Node 22) clean on both files.
  • vitepress build docs renders clean (build complete, no errors).
  • grep for residual "widen IRevisioned to long" guidance returns only the new, correct reversal/ILongVersioned content.

Refs #4533, #4526, #4528, #348.

🤖 Generated with Claude Code

jeremydmiller and others added 2 commits May 20, 2026 14:09
…ion for the #4533 revert

An early 9.0 alpha widened IRevisioned.Version to long; #4533 reverted that
before rc.1 (IRevisioned stays int, V8-compatible) and added ILongVersioned
(long) for MultiStreamProjection documents whose Version is the global event
sequence number. The migration guide still told users to widen Version to long.

Rewrite the section to lead with the reversal, introduce ILongVersioned with the
Int32-overflow rationale, and replace the widen-to-long example with a correct
IRevisioned(int)/ILongVersioned(long) pair. Every Before|After type in the table
was verified against origin/master source: IRevisioned.Version is int (unchanged);
DocumentMetadata.CurrentRevision, UpdateRevision/TryUpdateRevision parameters,
IRevisionedOperation.Revision and the m.Revision metadata column are long (and
source-compatible via int->long). Dropped the stale claim that MapTo to an int
property throws (RevisionColumn now accepts int or long). References updated to
#4533 / #4526 / #4528 / #348; #3733 / #4377 are historical.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
…nippet (int Version)

The embedded sample_versioned_reservation snippet still showed long Version even
though its source (src/Marten.Testing/Examples/RevisionedDocuments.cs) was already
reverted to int by #4533. Regenerated via mdsnippets so the embed matches source.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@jeremydmiller jeremydmiller merged commit 75aec57 into master May 20, 2026
1 check passed
@jeremydmiller jeremydmiller deleted the docs/4533-fix-stale-irevisioned-widening branch May 20, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant