Skip to content

Conversation

@haohaocreates
Copy link

@haohaocreates haohaocreates commented May 22, 2024

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.

The main benefits are that authors can

  • publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
  • automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

  • Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
  • Write a short description.
  • Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish

Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

@JaredTherriault
Copy link
Owner

Thank you for the PR! I have some hesitations about merging however:

  1. The request involves me signing up for a third party account which at first glance appears entirely opaque. The stated mission seems like a good one - the opportunity for conflicts in disparate comfy suites is huge, especially with irresponsible morons like myself naming their suite something as generic as "JNodes." That said, I don't have any immediate insight into how the platform you've suggested works, and as such I am hesitant to sign up without seeing the code or at least having a trusted party vouch for the platform.
  2. I'm not familiar with you or your previous work so for all I know this could be a massive data collection scheme.
  3. I've seen you make this PR to many, many repositories in a relatively short amount of time. Not that this is in and of itself an issue per se, but it does raise red flags for me.

Could you speak more to how this platform came about, information about who the people behind it are, etc? I saw the document you linked, but I think I need a bit more convincing.

Thank you!

@haohaocreates
Copy link
Author

haohaocreates commented May 24, 2024

Thank you for the PR! I have some hesitations about merging however:

  1. The request involves me signing up for a third party account which at first glance appears entirely opaque. The stated mission seems like a good one - the opportunity for conflicts in disparate comfy suites is huge, especially with irresponsible morons like myself naming their suite something as generic as "JNodes." That said, I don't have any immediate insight into how the platform you've suggested works, and as such I am hesitant to sign up without seeing the code or at least having a trusted party vouch for the platform.
  2. I'm not familiar with you or your previous work so for all I know this could be a massive data collection scheme.
  3. I've seen you make this PR to many, many repositories in a relatively short amount of time. Not that this is in and of itself an issue per se, but it does raise red flags for me.

Could you speak more to how this platform came about, information about who the people behind it are, etc? I saw the document you linked, but I think I need a bit more convincing.

Thank you!

Thank you for the PR! I have some hesitations about merging however:

  1. The request involves me signing up for a third party account which at first glance appears entirely opaque. The stated mission seems like a good one - the opportunity for conflicts in disparate comfy suites is huge, especially with irresponsible morons like myself naming their suite something as generic as "JNodes." That said, I don't have any immediate insight into how the platform you've suggested works, and as such I am hesitant to sign up without seeing the code or at least having a trusted party vouch for the platform.
  2. I'm not familiar with you or your previous work so for all I know this could be a massive data collection scheme.
  3. I've seen you make this PR to many, many repositories in a relatively short amount of time. Not that this is in and of itself an issue per se, but it does raise red flags for me.

Could you speak more to how this platform came about, information about who the people behind it are, etc? I saw the document you linked, but I think I need a bit more convincing.

Thank you!

Totally reasonable concerns to have let me respond rq!!!

  1. So, for the frontend portion of the registry is public, we just transferred over from personal private repo). The backend shares the same API end points as https://comfyci.org/, and we're going to clean it up a bit more before making it public!
  2. This is completely fair to be weary of! We're also collaborating with Dr.Lt.Data and ComfyAnon in order to build this project. Eventually it'll be used as the default backend for comfyui manager.
  3. Yeah so originally I was making manual PRs one by one to each node pack LMAO, but then we thought it might be more efficient if we could automate this process and auto-PR against UI-manager's list.

Lastly, just wanted to say all of your questions are completely understandable and I can definitely empathize with where you are coming. Perhaps this is something we need to improve our messaging on and clarify in the future! A lot of other people have actually had similar questions, and if you want you can check out our discord (or even add me to hahha) here: https://discord.com/invite/S4ExxY7ff8

Hopefully this helps, lmk if you have more questions!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants