Skip to content

Content Encoding Handling#129

Merged
TheMarstonConnell merged 2 commits intomainfrom
marston/encoding
Jul 10, 2025
Merged

Content Encoding Handling#129
TheMarstonConnell merged 2 commits intomainfrom
marston/encoding

Conversation

@TheMarstonConnell
Copy link
Member

@TheMarstonConnell TheMarstonConnell commented Jul 10, 2025

Should reduce the amount of failed downloads due to merkle mismatches

Summary by CodeRabbit

  • New Features

    • Improved download functionality to support files compressed with gzip, deflate, and Brotli encodings.
  • Chores

    • Updated dependencies to include Brotli compression support.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 10, 2025

Walkthrough

The changes add support for handling compressed HTTP response bodies in the file download logic by detecting the Content-Encoding header and using the appropriate decompression reader. The Brotli decompression library is added as an indirect dependency. No changes are made to public APIs or exported function signatures.

Changes

File(s) Change Summary
go.mod Added github.com/andybalholm/brotli v1.2.0 as an indirect dependency.
network/downloads.go Enhanced DownloadFileFromURL to handle gzip, deflate, and Brotli-encoded HTTP responses.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant DownloadFileFromURL
    participant HTTPServer

    Caller->>DownloadFileFromURL: Call with URL
    DownloadFileFromURL->>HTTPServer: Send HTTP GET request
    HTTPServer-->>DownloadFileFromURL: Respond with body and Content-Encoding
    alt Content-Encoding is gzip
        DownloadFileFromURL->>DownloadFileFromURL: Wrap body with gzip.Reader
    else Content-Encoding is deflate
        DownloadFileFromURL->>DownloadFileFromURL: Wrap body with flate.Reader
    else Content-Encoding is br
        DownloadFileFromURL->>DownloadFileFromURL: Wrap body with brotli.Reader
    else No encoding or unknown
        DownloadFileFromURL->>DownloadFileFromURL: Use raw body
    end
    DownloadFileFromURL->>DownloadFileFromURL: io.Copy to buffer
    DownloadFileFromURL-->>Caller: Return downloaded data
Loading

Poem

A bunny hops with nimble cheer,
Now downloads files both far and near—
Gzip, Brotli, flate, oh my!
Compressed or plain, it will not sigh.
With every hop, a byte set free,
Unzipping joy for you and me!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac63468 and 58673d2.

📒 Files selected for processing (1)
  • network/downloads.go (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • network/downloads.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: cov
  • GitHub Check: Test
  • GitHub Check: Build
  • GitHub Check: lint
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d97b4a and ac63468.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (1 hunks)
  • network/downloads.go (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: lint
  • GitHub Check: cov
  • GitHub Check: Test
  • GitHub Check: Build
🔇 Additional comments (4)
go.mod (1)

52-52: Brotli v1.2.0 is current and secure.

The latest release of github.com/andybalholm/brotli is v1.2.0 (July 1, 2025) and no known vulnerabilities have been reported. No further updates are required.

network/downloads.go (3)

5-6: LGTM - Import additions are appropriate.

The added compression library imports correctly support the new content encoding handling functionality.

Also applies to: 16-16


86-86: LGTM - Logging improvement.

Good refactoring to use Msgf instead of Msg(fmt.Sprintf(...)) for more idiomatic logging.


187-187: LGTM - Proper use of decompressed reader.

The change from resp.Body to bodyReader correctly uses the decompressed content stream, which should resolve merkle mismatch issues caused by compressed responses.

@TheMarstonConnell TheMarstonConnell merged commit 599c028 into main Jul 10, 2025
6 checks passed
@TheMarstonConnell TheMarstonConnell deleted the marston/encoding branch July 10, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant