German translation fix #1988

mairdl · 2016-09-15T16:55:13Z

The German translation of JabRef has some issues, have a look at the following screenshot:

The function to open a database is called Datei öffnen the displayed hotkey is F4. In the English version of JabRef the file menu looks like this:

As you can see the right hotkey for this function should beCTRL + O. Also, the word database gets translated as Datei instead of Datenbank.

This PR aims to fix this issue by rewording the translation. Every English occurrence of databaseis now translated as Datenbank. This is what it looks like now:

- [x] Change in CHANGELOG.md described - [x] Manually tested changed features in running JabRef - [x] internal qs

Siedlerchr · 2016-09-15T17:13:54Z

This PR aims to fix this issue by rewording the translation. Every English occurrence of databaseis now translated as Datenbank

I doubt that this is a good idea!
We differ between a Bibtex-Database (Datei (because it is not a real Datenbank) and a real SQL-Database (Datenbank). The question is more likely: Why is ist called "database" in english?
And the answer is possibly Historic reason...
@koppor

koppor · 2016-09-15T19:38:35Z

I discussed with @mairdl and others here. The English menu strings are the leading strings. And we currently have "Database" there.

I know that this is confusing. This also confused me multiple times.

What @mairdl didn't show that we also have a Tools menu with "Open file". There, the attached (!) file is shown. We thought that is is a good idea to distinguish between (linked/attached) files (== files) and bib files (== database).

For now, I would merge this in. Otherwise we have to change all translations.

mairdl · 2016-09-16T10:51:16Z

A screenshot of the Tools/Extra menu:

To open an attached file you select Datei öffnen same as to open a new database.

tschechlovdev · 2016-09-16T12:32:29Z

src/main/resources/l10n/JabRef_de.properties

 Automatically_sync_bibliography_when_inserting_citations=Bibliographie_beim_Einfügen_von_Literaturverweisen_automatisch_synchronisieren
 Look_up_BibTeX_entries_in_the_active_tab_only=BibTeX-Einträge_nur_im_aktiven_Tab_suchen
-Look_up_BibTeX_entries_in_all_open_databases=BibTeX-Einträge_in_allen_geöffneten_Dateien_suchen
+Look_up_BibTeX_entries_in_all_open_databases=BibTeX-Einträge_in_allen_geöffneten_Datenbank_suchen


Datenbanken

tschechlovdev · 2016-09-16T12:33:25Z

src/main/resources/l10n/JabRef_de.properties

-This_feature_generates_a_new_database_based_on_which_entries_are_needed_in_an_existing_LaTeX_document.=Diese_Funktion_erstellt_eine_neue_Datei_basierend_auf_den_Einträgen,_die_von_einem_bestehenden_LaTeX-Dokument_benötigt_werden.
-You_need_to_select_one_of_your_open_databases_from_which_to_choose_entries,_as_well_as_the_AUX_file_produced_by_LaTeX_when_compiling_your_document.=Sie_müssen_eine_Ihrer_geöffneten_Dateien,_von_denen_Einträge_genommen_werden_sollen,_sowie_die_AUX-Datei,_die_von_LaTeX_beim_Kompilieren_Ihres_Dokuments_erstellt_wird,_auswählen.
+This_feature_generates_a_new_database_based_on_which_entries_are_needed_in_an_existing_LaTeX_document.=Diese_Funktion_erstellt_eine_neue_Datenbank_basierend_auf_den_Einträgen,_die_von_einem_bestehenden_LaTeX-Dokument_benötigt_werden.
+You_need_to_select_one_of_your_open_databases_from_which_to_choose_entries,_as_well_as_the_AUX_file_produced_by_LaTeX_when_compiling_your_document.=Sie_müssen_eine_Ihrer_geöffneten_Datenbank,_von_denen_Einträge_genommen_werden_sollen,_sowie_die_AUX-Datei,_die_von_LaTeX_beim_Kompilieren_Ihres_Dokuments_erstellt_wird,_auswählen.


geöffneten Datenbanken

tschechlovdev · 2016-09-16T12:35:19Z

src/main/resources/l10n/Menu_de.properties

+Open_database=Datenbank_\u00f6&ffnen
 Open_URL_or_DOI=&URL_oder_DOI_\u00f6ffnen
-Open_shared_database=Entfernte_Datenbak_öffnen
+Open_shared_database=Entfernte_Datenbank_öffnen


Why is shared translated with "entfernte" ?

This is a translation of @obraliar as far as I know

I would go for "Geteilte_Datenbank_öffnen"

Yeah, but "Entfernte" is really confusing I think. "Geteilte" sounds good.

You changed the other strings to "Geteilte" so this needs to be changed, too.

tschechlovdev · 2016-09-16T12:42:10Z

src/main/resources/l10n/Menu_de.properties

-Import_into_new_database=&Importieren_in_neue_Datenbank
-Import_into_current_database=Importieren_in_aktuelle_&Datenbank
+Import_into_new_database=&Importiere_in_neue_Datenbank
+Import_into_current_database=Importiere_in_aktuelle_&Datenbank


In my opinion "Importieren" is better than "importiere".

Ok I will invert it then

Please change it to "Importieren".

tschechlovdev · 2016-09-16T12:46:56Z

src/main/resources/l10n/JabRef_de.properties

 Entry_type_to_be_created\:=Eintragstyp,_der_erstellt_werden_soll\:
 Searching_file_system...=Dateisystem_wird_durchsucht...
-Importing_into_Database...=Importieren_in_die_Datei...
+Importing_into_Database...=Importieren_in_die_Datenbank...


You should stay consistent here. If you decide for "Importiere" below, then you should also use here "Importiere".

Still not fixed. It should be In die Datenbank importieren...

boceckts

Minor comments need to be addressed than it's good to me.

boceckts · 2016-09-19T10:22:46Z

CHANGELOG.md

 - Implemented integrity check for `note` and `howpublished` field: Should have the first letter capitalized (BibTeX)
 - <kbd>Pos1</kbd> / <kbd>HOME</kbd> now select the first/last entry in the main table and the search result frame.
 - <kbd>UP</kbd> / <kbd>Down</kbd> / <kbd>Tab</kbd> / <kbd>shift+Tab</kbd> in the search result frame have now the same functionality as in the main  table.
+- Generalize german translation of database into "Datenbank"


Please aslo add a comment in the Fixed section that you fixed the keybinding bug when using the german language.

Please write "German" in with capital G

boceckts · 2016-09-19T10:30:27Z

src/main/resources/l10n/Menu_de.properties

-Import_into_new_database=&Importieren_in_neue_Datenbank
-Import_into_current_database=Importieren_in_aktuelle_&Datenbank
+Import_into_new_database=&Importiere_in_neue_Datenbank
+Import_into_current_database=Importiere_in_aktuelle_&Datenbank


Please change it to "Importieren".

boceckts · 2016-09-19T10:31:20Z

src/main/resources/l10n/Menu_de.properties

+Open_database=Datenbank_\u00f6&ffnen
 Open_URL_or_DOI=&URL_oder_DOI_\u00f6ffnen
-Open_shared_database=Entfernte_Datenbak_öffnen
+Open_shared_database=Entfernte_Datenbank_öffnen


You changed the other strings to "Geteilte" so this needs to be changed, too.

…e, add that information to the CHANGELOG.md

# Conflicts: # CHANGELOG.md

tobiasdiez · 2016-09-19T21:13:16Z

I didn't inspect the changes closely, but how did you fixed the wrong keyboard shortcut? I just saw a few changes in the properties files but nothing related to keyboard shortcuts.

Btw: Zotero, Mendeley and Papers all call it "Library".

koppor · 2016-09-19T22:29:00Z

It "magically" solved the shortcut issue. Maybe the shortcuts are stored using the translate menu items? @Braunch @mairdl Any comments?

If we change from "database" to "library", we have to change all translations everywhere and also the text at help.jabref.org. Let's discuss this at the dev call.

# Conflicts: # CHANGELOG.md

mairdl · 2016-09-20T14:38:30Z

I think JabRef would assign the wrong keybinding, because of the same german translation for 2 diffrent actions.

koppor · 2016-09-20T17:43:19Z

CHANGELOG.md

 - <kbd>Pos1</kbd> / <kbd>HOME</kbd> now select the first/last entry in the main table and the search result frame.
 - <kbd>UP</kbd> / <kbd>Down</kbd> / <kbd>Tab</kbd> / <kbd>shift+Tab</kbd> in the search result frame have now the same functionality as in the main  table.
 - Importer for MODS format added
+- Generalize german translation of database into "Datenbank"


Typo. German

…anslationFix # Conflicts: # CHANGELOG.md

koppor · 2016-09-22T05:50:54Z

CHANGELOG.md

 - Fixed [#1958](https://github.com/JabRef/jabref/issues/1958): Verbatim fields are no longer checked for HTML encoded characters by integrity checks
 - Fixed [#1937](https://github.com/JabRef/jabref/issues/1937): If no help page for the current chosen language exists, the english help page will be shown
 - Fixed [#1996](https://github.com/JabRef/jabref/issues/1996): Unnecessary other fields tab in entry editor removed (BibTeX mode)
+- Fixed file menu displays wrong hotkey in the german translation


koppor · 2016-09-22T05:51:46Z

src/main/resources/l10n/Menu_de.properties

 Switch_to_%0_mode=In_den_%0-Modus_wechseln
 Push_entries_to_external_application_(%0)=&Eintr\u00e4ge_in_externe_Anwendung_einf\u00fcgen_(%0)
-Pull_changes_from_shared_database=Entfernte_Änderungen_beziehen
+Pull_changes_from_shared_database=\u00c4nderungen_der_geteilten_Datenbank_beziehen


Do not use \u00c4, use the Umlaut directly. We have UTF-8 and this works perfectly.

Sometimes the Umlaut isn't used, I guess I could change all of them. Shall I do that?

Yes,! The tests will fail if you use the encoded \uXXX things. Make sure to replac them all (I had to change it in the Italian lang files)
e

koppor · 2016-09-22T05:53:03Z

@mairdl Please resolve conflicts, address the minor comments. Then it should good to go

@JabRef/stupro-qa Could you please double-check the final changes by @mairdl? It seems, the Importiere/Importieren thing could not have been solved consistently.

…anslationFix # Conflicts: # CHANGELOG.md

boceckts · 2016-09-26T17:16:10Z

Can you please update the screenshots in your description?

koppor · 2016-09-26T17:28:16Z

CHANGELOG.md

 - Fixed loop when pulling changes (shared database) when current selected field has changed
 - Fixed [#1958](https://github.com/JabRef/jabref/issues/1958): Verbatim fields are no longer checked for HTML encoded characters by integrity checks
 - Fixed [#1937](https://github.com/JabRef/jabref/issues/1937): If no help page for the current chosen language exists, the english help page will be shown
+- Fixed [#1996](https://github.com/JabRef/jabref/issues/1996): Unnecessary other fields tab in entry editor removed (BibTeX mode)


This is not part of this PR, is it?

must have slipped in by mistake

Probably because the original was unoded a few days ago,

boceckts · 2016-09-26T17:22:35Z

src/main/resources/l10n/JabRef_de.properties

 Entry_type_to_be_created\:=Eintragstyp,_der_erstellt_werden_soll\:
 Searching_file_system...=Dateisystem_wird_durchsucht...
-Importing_into_Database...=Importieren_in_die_Datei...
+Importing_into_Database...=In die Datenbank importieren...


Underscores are missing here

boceckts · 2016-09-26T17:25:25Z

src/main/resources/l10n/JabRef_de.properties

-should_contain_an_integer_or_a_literal=
-should_have_the_first_letter_capitalized=
+should_contain_an_integer_or_a_literal=Sollte einen Integer oder einen Literal enthalten
+should_have_the_first_letter_capitalized=Sollte den ersten Buchstaben großgeschrieben haben


Not really part of this pr but if you want to translate it please replace spaces by underscores.

boceckts · 2016-09-26T17:25:36Z

src/main/resources/l10n/JabRef_de.properties

+should_be_an_integer_or_normalized=Sollte ein Integer oder normalisiert sein
+should_be_normalized=Sollte normalisiert sein
+empty_BibTeX_key=Leerer BibTeX-Key
+BibLaTeX_field_only=Nur ein BibLaTeX-Feld


Same aslast comment.

boceckts · 2016-09-26T17:29:17Z

src/main/resources/l10n/Menu_de.properties

-Next_preview_layout=
-Previous_preview_layout=
+Next_preview_layout=Nächstes Vorschaulayout
+Previous_preview_layout=Vorheriges Vorschaulayout


Same problem with underscores.

…anslationFix # Conflicts: # CHANGELOG.md

mairdl · 2016-09-27T15:16:39Z

Travis seems to be unrelated

…anslationFix # Conflicts: # CHANGELOG.md

matthiasgeiger

LGTM

koppor · 2016-09-29T11:25:40Z

"Zuletzt geöffenete Dateien" still shows "Datei" and not "Database"

mairdl · 2016-09-29T14:01:02Z

Well in English it says recent files soi I kept it that way. If the key changes i can change it 🎅

koppor · 2016-09-29T14:07:24Z

Why not changing the key (with all consequences), too?

mairdl · 2016-09-29T14:24:06Z

because that is not related to this PR, this would have to be a seperate one (This PR focuses on the German translation, your suggested change would include all language files) I will create a PR for your suggestion. (link will follow soon)

* Generalize german translation of database into "Datenbank" * add changes to CHANGELOG.md * Some spelling fixes * Fix some spellings, change confusing translations * revert changes of "importieren", change translation of shared database, add that information to the CHANGELOG.md * Fix typo * Replace database translated as Datei with Datenbank, streamline importieren * Remove unused keys * Revert changes, improve translation * add missing German translations, use Umlaut directly in Menu_de * Add missing underscores * Remove unrelated CHANGELOG entry * Remove duplicates * Add missing German translations * Fix typo

mairdl added 3 commits September 15, 2016 16:57

Generalize german translation of database into "Datenbank"

5c1273c

add changes to CHANGELOG.md

998b4d5

Some spelling fixes

cd7854d

boceckts added stupro labels Sep 15, 2016

tschechlovdev reviewed Sep 16, 2016

View reviewed changes

Fix some spellings, change confusing translations

f4586be

boceckts suggested changes Sep 19, 2016

View reviewed changes

mairdl added 2 commits September 19, 2016 13:46

revert changes of "importieren", change translation of shared databas…

6b5b32d

…e, add that information to the CHANGELOG.md

Merge remote-tracking branch 'upstream/master' into GermanTranslationFix

a130efc

# Conflicts: # CHANGELOG.md

boceckts approved these changes Sep 19, 2016

View reviewed changes

boceckts added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Sep 19, 2016

boceckts changed the title ~~[WIP] German translation fix~~ German translation fix Sep 19, 2016

boceckts mentioned this pull request Sep 19, 2016

Implementation of LiveUpdate for PostgreSQL & Oracle systems #2009

Merged

4 tasks

Merge remote-tracking branch 'upstream/master' into GermanTranslationFix

0313880

# Conflicts: # CHANGELOG.md

koppor added the status: devcall label Sep 20, 2016

koppor reviewed Sep 20, 2016

View reviewed changes

mairdl added 2 commits September 21, 2016 11:36

Fix typo

96d0305

21-09-16 Merge remote-tracking branch 'upstream/master' into GermanTr…

a0f4169

…anslationFix # Conflicts: # CHANGELOG.md

koppor reviewed Sep 22, 2016

View reviewed changes

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 22, 2016

mairdl added 4 commits September 26, 2016 15:02

26.09.16 Merge remote-tracking branch 'upstream/master' into GermanTr…

398a063

…anslationFix # Conflicts: # CHANGELOG.md

26.09.16 Merge remote-tracking branch 'upstream/master' into GermanTr…

3997c1f

…anslationFix # Conflicts: # CHANGELOG.md

add missing German translations, use Umlaut directly in Menu_de

1435cfc

26.09.16 Merge remote-tracking branch 'upstream/master' into GermanTr…

d8722d6

…anslationFix # Conflicts: # CHANGELOG.md

koppor reviewed Sep 26, 2016

View reviewed changes

boceckts reviewed Sep 26, 2016

View reviewed changes

mairdl added 5 commits September 27, 2016 12:21

Add missing underscores

cace3eb

27.09.16 Merge remote-tracking branch 'upstream/master' into GermanTr…

011260f

…anslationFix # Conflicts: # CHANGELOG.md

Remove unrelated CHANGELOG entry

a1ec980

Remove duplicates

e90db9b

Add missing German translations

f88972b

mairdl force-pushed the GermanTranslationFix branch from cf01bda to f88972b Compare September 27, 2016 11:50

Fix typo

8c9244a

28.09.16 Merge remote-tracking branch 'upstream/master' into GermanTr…

093e242

…anslationFix # Conflicts: # CHANGELOG.md

boceckts added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 28, 2016

matthiasgeiger approved these changes Sep 28, 2016

View reviewed changes

matthiasgeiger merged commit 016a1df into JabRef:master Sep 28, 2016

mairdl deleted the GermanTranslationFix branch September 28, 2016 15:32

mairdl mentioned this pull request Sep 28, 2016

[WIP] German translation fix java fx #2086

Closed

koppor mentioned this pull request Sep 29, 2016

Replace "Database" by "Library" in the translation #2095

Closed

tobiasdiez removed the status: devcall label Sep 29, 2016

mairdl mentioned this pull request Sep 30, 2016

Change "Recent Files" to "Recent Databases" #2103

Merged

5 tasks

koppor mentioned this pull request Dec 16, 2019

JabRef 5.0: Main menus "File" & "Library" are confusing #5698

Closed

Uh oh!

German translation fix #1988

German translation fix #1988

Uh oh!

Conversation

mairdl commented Sep 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Sep 15, 2016

Uh oh!

koppor commented Sep 15, 2016

Uh oh!

mairdl commented Sep 16, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor Sep 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boceckts left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tobiasdiez commented Sep 19, 2016

Uh oh!

koppor commented Sep 19, 2016

Uh oh!

mairdl commented Sep 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mairdl Sep 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koppor commented Sep 22, 2016

Uh oh!

boceckts commented Sep 26, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

mairdl commented Sep 15, 2016 •

edited

Loading

koppor Sep 22, 2016 •

edited

Loading

mairdl Sep 22, 2016 •

edited

Loading