Skip to content

Conversation

@calixtus
Copy link
Member

@calixtus calixtus commented Sep 13, 2025

Refs #12655 (Importing into a present, observable and mutable preferences object)

Refs #10177 (Cleaning up dependencies to prefs)
Refs #12990 (Cleaning up JabRefGuiPreferences / JabRefCliPreferences
Follow up to #10002

Steps to test

Mandatory checks

@calixtus calixtus self-assigned this Sep 13, 2025
@calixtus calixtus added dev: code-quality Issues related to code or architecture decisions component: preferences labels Sep 13, 2025
@koppor
Copy link
Member

koppor commented Sep 14, 2025

Related (because language dependent): #13901

@koppor koppor mentioned this pull request Sep 14, 2025
2 tasks
@trag-bot
Copy link

trag-bot bot commented Sep 18, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor added the status: changes-required Pull requests that are not yet complete label Nov 20, 2025
# Conflicts:
#	jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java
#	jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java
@github-actions github-actions bot removed the status: changes-required Pull requests that are not yet complete label Nov 20, 2025
@koppor
Copy link
Member

koppor commented Nov 20, 2025

Prototype for workspace preferences - needs to be continued for the other preferences.

We prepared the UI under the assumption that the adaption will be done soon.

@koppor
Copy link
Member

koppor commented Nov 20, 2025

Strange that following string still apperas:

- "You must restart JabRef for this to come into effect."

@koppor koppor marked this pull request as ready for review November 20, 2025 14:02
@calixtus
Copy link
Member Author

Strange that following string still apperas:

- "You must restart JabRef for this to come into effect."

Fixed. Was about a duplicated property in WorkspacePreferences that was removed.

@koppor
Copy link
Member

koppor commented Nov 20, 2025

No CHANGELOG.md yet, because issue #12655 not fixed.

The behavior of removing the warning message is too little.

@koppor koppor enabled auto-merge November 20, 2025 14:20
@koppor koppor added this pull request to the merge queue Nov 20, 2025
@calixtus
Copy link
Member Author

calixtus commented Nov 20, 2025

Working pattern for followup PRs:
In JabRefGui/CliPreferences remove
grafik

In XXXPreferences class

  • Add private default constructor
grafik
  • Add getDefault method
grafik
  • Add setAll method
grafik

In JabRefGui/CliPreferences class

  • Add fromBackingStore method
grafik
  • Modify getXXXPreferences method
grafik
  • Add to clear / importPreferences method
grafik

return workspacePreferences;
}

private WorkspacePreferences getWorkspacePreferencesFromLowLevelApi(WorkspacePreferences defaults) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be renamed in followup to "getWorkspacePreferencesFromBackingStore"

Merged via the queue into main with commit 75d5d52 Nov 20, 2025
53 checks passed
@koppor koppor deleted the fix-prefs branch November 20, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: preferences dev: code-quality Issues related to code or architecture decisions project: jabcon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants