-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Observable Preferences Y (Resetting preferences) #13894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Related (because language dependent): #13901 |
|
@trag-bot didn't find any issues in the code! ✅✨ |
# Conflicts: # jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTab.java # jabgui/src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java
|
Prototype for workspace preferences - needs to be continued for the other preferences. We prepared the UI under the assumption that the adaption will be done soon. |
|
Strange that following string still apperas: - "You must restart JabRef for this to come into effect." |
Fixed. Was about a duplicated property in WorkspacePreferences that was removed. |
|
No CHANGELOG.md yet, because issue #12655 not fixed. The behavior of removing the warning message is too little. |
| return workspacePreferences; | ||
| } | ||
|
|
||
| private WorkspacePreferences getWorkspacePreferencesFromLowLevelApi(WorkspacePreferences defaults) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be renamed in followup to "getWorkspacePreferencesFromBackingStore"







Refs #12655 (Importing into a present, observable and mutable preferences object)
Refs #10177 (Cleaning up dependencies to prefs)
Refs #12990 (Cleaning up JabRefGuiPreferences / JabRefCliPreferences
Follow up to #10002
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)