Skip to content

Conversation

@seanmcleod
Copy link
Member

Slightly messy layout in FGAtmosphere.h in terms of ideally wanting to add StdDaySLdensity to the existing group of public constants.

  static constexpr double StdDaySLtemperature = 518.67;
  static constexpr double StdDaySLpressure = 2116.228;
  const double StdDaySLsoundspeed;
  static constexpr double SHRatio = 1.4;

But require Reng0 to be defined first, but it's currently lower down in a protected section.

So couple of options in terms, not sure if the one I've chosen is the best.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #900 (31ca720) into master (02b4e25) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   23.10%   23.09%   -0.01%     
==========================================
  Files         167      167              
  Lines       19627    19626       -1     
==========================================
- Hits         4534     4533       -1     
  Misses      15093    15093              
Impacted Files Coverage Δ
src/FGFDMExec.cpp 41.40% <ø> (-0.09%) ⬇️
src/models/FGAtmosphere.h 100.00% <ø> (ø)
src/models/FGAuxiliary.cpp 66.00% <0.00%> (ø)

Copy link
Member

@bcoconni bcoconni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bcoconni
Copy link
Member

But require Reng0 to be defined first, but it's currently lower down in a protected section.

Not sure there is much reason for this constant to be hidden behind a protected wall. At some point maybe it should be renamed to R_dry_air or any name that is more explicit than Reng0 ?

So couple of options in terms, not sure if the one I've chosen is the best.

You've chosen the most conservative which is fine as far as I am concerned 😄.

@bcoconni bcoconni merged commit 56c4edc into JSBSim-Team:master Apr 28, 2023
bcoconni pushed a commit to bcoconni/jsbsim that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants