Skip to content

Conversation

@LilithSilver
Copy link
Contributor

This PR updates the README file with instructions for building/including in a non-Unreal C++ project (it's currently a bit of a pain and took me a while to figure out). It also updates the example and provides some troubleshooting steps.

I also included an error check in the STL file read ifstream mode to ensure the file was opened properly. It earlier failed on the parsing step and produced an endianness error; it now properly reports the error to the user. I included this because it also tripped me up for a bit.

The test file passes when I run it with -C Release, but not -C Debug (standing issue, not caused by my changes).

Let me know if I should change or add anything!

@JBenda
Copy link
Owner

JBenda commented Jun 2, 2022

Thanks for updating the readme . The additional error check is a good idea :+1
But could you add the name of the file to the error message, this might be usefull if the user generates its filenames.

@LilithSilver
Copy link
Contributor Author

But could you add the name of the file to the error message, this might be usefull if the user generates its filenames.

Pushed!

@JBenda JBenda merged commit 689c07d into JBenda:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants