Implemented Tags #26
Implemented Tags #26
Conversation
| { | ||
| // TODO: Why is this true again? | ||
| _emitter->write_path(Command::READ_COUNT, CommandFlag::NO_FLAGS, val, true); | ||
| _emitter->write_path(Command::READ_COUNT, CommandFlag::NO_FLAGS, val, false); |
There was a problem hiding this comment.
I'm going to investigate this before I approve. Just to make sure...
There was a problem hiding this comment.
Okay, this actually needs to be true and the fact it's failing means there's another issue. With your change, the CNT? command actually won't work anymore because it's expecting an index in the container visits table, not the actual byte offset of the container in the instruction data. Can you create a new issue in GitHub with the failing file and the error message?
|
The tags defined from Inkle works different, their tags are only enabled for a line per default. Also, you are able to define tags for knots which than can be queried and also global tags are existed, the different cases are missing in this implementation. |
|
Added test cases and a bit documentation ^^, it works the same way as "inklecate" |
|
Looks like a windows unit test is failing, but passing on linux/mac? Seems like an extra 0 is being inserted into the output for some reason. |
|
It was a missing NULL terminator when setting a global string from program, no idea why that did not fail earlier. |
|
The fix is now in #30 |
|
Closed because fork is deleted, continue in #32 |
3 participants
Added tag ( '#') parsing and runtime ability to query tags.