Advance InkProof B006, B007 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brwarner
reviewed
Feb 9, 2021
brwarner
approved these changes
Feb 9, 2021
Collaborator
brwarner
left a comment
brwarner
left a comment
There was a problem hiding this comment.
Looks great. Clever string compare. Might be nice to have a few unit tests for it in the future but I'm happy with everything for now.
Owner
Author
|
Fair point, but isn't this with ink-proof kind of redundant? |
Collaborator
|
I guess I'm not sure how extensively ink-proof would test problem cases in
this algorithm.
Something like comparing (& is string append)
4 & 55 & "hello"
with
45 & "5hello"
Is the kind of case you'd want to write a test for knowing how your
algorithm works. It's not the kind of test ink-proof is going to have.
…On Wed, Feb 10, 2021 at 1:28 AM JBenda ***@***.***> wrote:
Fair point, but isn't this with ink-proof kind of redundant?
I will implement some test ^^ (soon TM)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIAEVDZUJQ2LJRT3OSLIG3S6JGUZANCNFSM4XJLD55A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to accomplish as much InkProofnes with the current feature set as possible.