Skip to content

Convert project to esm #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Convert project to esm #35

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
409b02c
chore(package.json): bump normalize-url version and change project ty…
edenhermelin Apr 14, 2022
a10861c
chore: update project to use ESM imports
edenhermelin Apr 14, 2022
fa1c39c
Merge branch 'master' into convert-project-to-esm
edenhermelin Apr 14, 2022
1719b97
Merge branch 'master' of https://github.com/edenhermelin/parse-url in…
edenhermelin Jul 17, 2022
3e558c5
fix(test): change import for tests to support ESM
edenhermelin Jul 17, 2022
b04fbbb
Merge branch 'master' into convert-project-to-esm
IonicaBizau Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Dependencies
const parseUrl = require("../lib")
import parseUrl from "../lib/index.js";

console.log(parseUrl("http://ionicabizau.net/blog"))
// {
Expand Down
6 changes: 3 additions & 3 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
"use strict"
Copy link
Contributor

@privatenumber privatenumber Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESM files are strict by default


// Dependencies
const parsePath = require("parse-path")
, normalizeUrl = require("normalize-url")
import parsePath from "parse-path";
import normalizeUrl from "normalize-url";


/**
Expand Down Expand Up @@ -71,4 +71,4 @@ const parseUrl = (url, normalize = false) => {
return parsed;
}

module.exports = parseUrl;
export default parseUrl;
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"name": "parse-url",
"version": "7.0.2",
"version": "7.0.3",
"description": "An advanced url parser supporting git urls too.",
"main": "lib/index.js",
"type": "module",
"directories": {
"example": "example",
"test": "test"
Expand Down Expand Up @@ -32,7 +33,7 @@
},
"dependencies": {
"is-ssh": "^1.4.0",
"normalize-url": "^6.1.0",
"normalize-url": "^7.0.3",
"parse-path": "^5.0.0",
"protocols": "^2.0.1"
},
Expand Down
7 changes: 3 additions & 4 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// Dependencies
const parseUrl = require("../lib")
, tester = require("tester")
, normalizeUrl = require("normalize-url")
;
import parseUrl from "../lib/index.js";
import tester from "tester";
import normalizeUrl from "normalize-url";

const INPUTS = [
[
Expand Down