Support gov/canonical/pparams/v0 namespace#5579
Merged
Conversation
qnikst
force-pushed
the
qnikst/canonical/gov/pparams/v0
branch
4 times, most recently
from
b0e0138 to
27feb2f
Compare
lehins
requested changes
Feb 23, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Sorry, but this is not a viable approach for protocol parameters. We can talk more about it later on today in the meeting(s).
.../cardano-ledger-canonical-state/src/Cardano/Ledger/CanonicalState/Namespace/GovPParams/V0.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Fixed all of the comments! |
qnikst
force-pushed
the
qnikst/canonical/gov/pparams/v0
branch
from
754a631 to
59374fb
Compare
lehins
reviewed
Feb 25, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Few things needs some adjustments, but overall looks good.
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Outdated
Show resolved
Hide resolved
.../cardano-ledger-canonical-state/src/Cardano/Ledger/CanonicalState/Namespace/GovPParams/V0.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/test/Test/Cardano/Ledger/CanonicalState/Spec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/test/Test/Cardano/Ledger/CanonicalState/Spec.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
Feb 25, 2026
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Show resolved
Hide resolved
qnikst
force-pushed
the
qnikst/canonical/gov/pparams/v0
branch
from
59374fb to
1a8f29a
Compare
Collaborator
Author
|
I've addressed (applied suggestions actually) all the comments |
qnikst
force-pushed
the
qnikst/canonical/gov/pparams/v0
branch
2 times, most recently
from
84d85c5 to
0c6608f
Compare
Collaborator
Author
|
UPD, now rebased atop of MapExtras and passed the tests. I've returned SRP because we still adjusting specs |
qnikst
force-pushed
the
qnikst/canonical/gov/pparams/v0
branch
3 times, most recently
from
2eb8d84 to
97fd769
Compare
lehins
approved these changes
Mar 2, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Some more changes are needed, but once those are addresses this PR is ready to go.
libs/cardano-ledger-canonical-state/src/Cardano/Ledger/CanonicalState/BasicTypes.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/test/Test/Cardano/Ledger/CanonicalState/Spec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/cardano-ledger-canonical-state.cabal
Outdated
Show resolved
Hide resolved
.../cardano-ledger-canonical-state/src/Cardano/Ledger/CanonicalState/Namespace/GovPParams/V0.hs
Outdated
Show resolved
Hide resolved
.../cardano-ledger-canonical-state/src/Cardano/Ledger/CanonicalState/Namespace/GovPParams/V0.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-canonical-state/conway/Cardano/Ledger/CanonicalState/Conway.hs
Outdated
Show resolved
Hide resolved
qnikst
force-pushed
the
qnikst/canonical/gov/pparams/v0
branch
from
0b05520 to
57cae10
Compare
Collaborator
Author
|
I've applied all suggestions, fixed compilation and updated the spec to support new keys. |
qnikst
force-pushed
the
qnikst/canonical/gov/pparams/v0
branch
from
0086519 to
2d8821d
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).