feat(singleton): ensure singleton thread safety and no performance degradation#205
Merged
sunpengsdu merged 1 commit intoInternLM:developfrom Jul 16, 2024
zigzagcai:singleton-thread-safety
Merged
feat(singleton): ensure singleton thread safety and no performance degradation#205sunpengsdu merged 1 commit intoInternLM:developfrom zigzagcai:singleton-thread-safety
sunpengsdu merged 1 commit intoInternLM:developfrom
zigzagcai:singleton-thread-safety
Conversation
Collaborator
Author
|
This enhancement has also been adopted and merged by ColossalAI |
sunpengsdu
approved these changes
Jul 16, 2024
sunpengsdu
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
During very large-scale training (especially gpus numer >=1024), it would be a high probability that we get stuck when launching training processes. We found the root cause a deadlock within singleton implementation in multhreading scenarios.
Modification
Refine singleton implementation to ensure thread-safety and no performance degradation.
We use the double checked locking algorithm for singleton metaclass.
BC-breaking (Optional)
None
Use cases (Optional)
None
Checklist
Before PR:
After PR: