Added genlock features to extend the option RS2_OPTION_INTER_CAM_SYNC…#8709
Merged
ev-mp merged 4 commits intoApr 8, 2021
Merged
Conversation
ev-mp
suggested changes
Apr 5, 2021
ev-mp
left a comment
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
@daversintel , thanks for the refactoring 👍
Several feedbacks inline.
2. Adde comments in function external_sync_mode::set. 3. Added comments in external_sync_mode constructor.
ev-mp
reviewed
Apr 6, 2021
ev-mp
suggested changes
Apr 6, 2021
ev-mp
left a comment
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
Function status to be dependent on streaming.
DSO-16833
Contributor
Author
|
Yes,it depends on streaming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing old pull request 8584 for adding genlock features to extend the option RS2_OPTION_INTER_CAM_SYN_MODE.
DSO-16833