Trim newlines utility function#7718
Merged
Merged
Conversation
Nir-Az
requested changes
Nov 5, 2020
| // fourth\n | ||
| inline std::string trim_newlines( std::string s ) | ||
| { | ||
| char const * const base = s.c_str(); |
Collaborator
There was a problem hiding this comment.
Can you add some comments to the code? What each section does?
maybe about the variables? you got s, base, src and dest , hard to understand what are their roles.
Nir-Az
reviewed
Nov 5, 2020
Nir-Az
left a comment
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
I would consider moving the file to the common folder instead of the utility one. it is more tailored function then a generic one.
Nir-Az
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.