Add time utility classes + UT#7452
Merged
maloel merged 5 commits intoOct 14, 2020
Merged
Conversation
Nir-Az
commented
Sep 30, 2020
Nir-Az
commented
Collaborator
- Add a space for common utility classes.
- Take timer helper functions from rendering.h , refactor + add functionality and place on timer.h utility file
- Replace all time functions usage with new classes
- Add unit tests for 3 new classes
Nir-Az
force-pushed
the
Add_timer_class_to_new_file
branch
from
1827198 to
eb6e619
Compare
maloel
reviewed
Oct 1, 2020
maloel
reviewed
Oct 1, 2020
maloel
reviewed
Oct 1, 2020
maloel
reviewed
Oct 1, 2020
maloel
reviewed
Oct 1, 2020
maloel
reviewed
Oct 1, 2020
maloel
reviewed
Oct 1, 2020
Nir-Az
force-pushed
the
Add_timer_class_to_new_file
branch
from
e224d4e to
97fda0e
Compare
Nir-Az
force-pushed
the
Add_timer_class_to_new_file
branch
from
97fda0e to
8cd5215
Compare
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
maloel
reviewed
Oct 12, 2020
Nir-Az
force-pushed
the
Add_timer_class_to_new_file
branch
from
9ad2133 to
c2e641c
Compare
maloel
reviewed
Oct 14, 2020
| CHECK_FALSE(t.has_expired()); | ||
|
|
||
| std::this_thread::sleep_for(std::chrono::milliseconds(500)); | ||
| std::this_thread::sleep_for(TEST_DELTA_TIME - std::chrono::milliseconds(400)); |
Contributor
There was a problem hiding this comment.
May not work if TEST_DELTA_TIME is < 400ms
Collaborator
Author
There was a problem hiding this comment.
Replaced with TEST_DELTA_TIME / 2
maloel
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.