Add capability to override the official SW update server url#6593
Merged
ev-mp merged 1 commit intoJun 16, 2020
Merged
Conversation
Nir-Az
commented
Jun 15, 2020
Nir-Az
commented
Collaborator
Nir-Az
force-pushed
the
sw_update_add_testing_URL_to_viewer_UI
branch
from
f14f7e5 to
3ec2879
Compare
ev-mp
suggested changes
Jun 15, 2020
ev-mp
left a comment
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
There are multiple formatting changes that are not essential in viewer.cpp - and some of them "break" the previous alignment like in lines 1463-1467.
can you drop those and leave only the new code?
| static const char* recommend_updates { "update.recommend_updates" }; | ||
| static const char* recommend_calibration { "update.recommend_calibration" }; | ||
| static const char* sw_updates_url { "update.sw_update_url" }; | ||
| static const char* sw_updates_operational_server { "update.sw_update_oprational_server" }; |
Collaborator
Author
There was a problem hiding this comment.
changed to official
| static const char* recommend_updates { "update.recommend_updates" }; | ||
| static const char* recommend_calibration { "update.recommend_calibration" }; | ||
| static const char* sw_updates_url { "update.sw_update_url" }; | ||
| static const char* sw_updates_operational_server { "update.sw_update_oprational_server" }; |
Collaborator
Author
There was a problem hiding this comment.
Changed to official
Nir-Az
force-pushed
the
sw_update_add_testing_URL_to_viewer_UI
branch
from
3ec2879 to
1ca7930
Compare
Nir-Az
force-pushed
the
sw_update_add_testing_URL_to_viewer_UI
branch
from
1ca7930 to
bc9c472
Compare
ev-mp
changed the title
ev-mp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.