remove rosdep 'linux-headers-generic'#5483
Merged
dorodnic merged 1 commit intoMar 5, 2020
Merged
Conversation
radfordi
approved these changes
Jan 28, 2020
tylerjw
approved these changes
Feb 3, 2020
Contributor
Author
|
Any news on this? |
Contributor
|
Thanks @christian-rauch , sorry for the delay |
|
This issue was closed before this fix was even submitted #4039 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
linux-headers-genericrosdep key does not guarantee that the headers of the running kernel will be installed. E.g. on a Ubuntu 18.04 LTS, the rosdep and packagelinux-headers-genericwill depend onlinux-headers-4.15.0-72-generic, while point releases (.2, .3, ...) will likely have packageslinux-headers-generic-hwe-18.04installed, which will depend onlinux-headers-5.0.0-37-generic.The build system has to determine the running kernel version in any case and this rosdep key just installs "old" unused header packages.