Option to preserve T265 maps in memory for subsequent starts#5208
Merged
Conversation
radfordi
changed the title
bfulkers-i
approved these changes
Nov 8, 2019
dorodnic
approved these changes
Dec 1, 2019
ev-mp
reviewed
Dec 4, 2019
ev-mp
left a comment
ev-mp
left a comment
Contributor
There was a problem hiding this comment.
Add it to C# wrapper
Documenting this feature would be useful:
- Default value
- When the option becomes available/disabled
- What happens after n-start/stop operation the map reaches its max. Does it stop update?
| RS2_OPTION_ENABLE_POSE_JUMPING, /**< Enable position jumping */ | ||
| RS2_OPTION_ENABLE_DYNAMIC_CALIBRATION, /**< Enable dynamic calibration */ | ||
| RS2_OPTION_DEPTH_OFFSET, /**< Offset from sensor to depth origin in millimetrers*/ | ||
| RS2_OPTION_ENABLE_MAP_PRESERVATION, /**< Preserve previous map when starting */ |
Contributor
There was a problem hiding this comment.
Pls keep the original order and append to end
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out. This needs a rebase after 3f82376.
| enable_relocalization (56) | ||
| enable_pose_jumping (57) | ||
| enable_dynamic_calibration (58) | ||
| enable_depth_offset (59) |
Contributor
There was a problem hiding this comment.
Check for consistency with c++ declaration
| count (62) | ||
| end | ||
| end No newline at end of file | ||
| end |
…(was the default)
radfordi
force-pushed
the
preserve-map
branch
from
3f82376 to
3d90daa
Compare
Contributor
Author
…(was the default)
radfordi
force-pushed
the
preserve-map
branch
from
3d90daa to
c6b56cb
Compare
This was referenced Dec 5, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.