Skip to content

improve and enable basic color test#14296

Merged
Nir-Az merged 4 commits into
realsenseai:developmentfrom
AviaAv:iq-basic-color
Sep 29, 2025
Merged

improve and enable basic color test#14296
Nir-Az merged 4 commits into
realsenseai:developmentfrom
AviaAv:iq-basic-color

Conversation

@AviaAv

@AviaAv AviaAv commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Tracked on: [LRS-1287]

@AviaAv AviaAv requested a review from Nir-Az September 17, 2025 08:05
@Nir-Az Nir-Az requested a review from Copilot September 18, 2025 11:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the basic color image quality test by implementing ArUco marker-based page detection for automated region of interest (ROI) identification and enables the test by removing the "donotrun" tag. The test now uses computer vision techniques to detect and analyze a standardized 3x3 color grid on an A4 page.

Key changes:

  • Replaces hardcoded pixel coordinates with dynamic ArUco marker detection for ROI alignment
  • Expands from 3 to 9 color samples in a structured 3x3 grid layout
  • Adds multiple resolution and framerate test configurations with conditional execution

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
unit-tests/requirements.txt Downgrade numpy to version 2.0.2 for Jetson compatibility
unit-tests/live/image-quality/test-basic-color.py Complete rewrite implementing ArUco detection, perspective transformation, and expanded color testing
Comments suppressed due to low confidence (1)

unit-tests/requirements.txt:1

  • numpy version 2.2.4 does not exist. The latest numpy 2.x series is 2.1.x as of my knowledge cutoff. Please verify this version exists before using it.
fastapi==0.115.12

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread unit-tests/live/image-quality/test-basic-color.py
Comment thread unit-tests/live/image-quality/test-basic-color.py Outdated
Comment thread unit-tests/live/image-quality/test-basic-color.py
Comment thread unit-tests/requirements.txt
# test:device D400*
# test:donotrun
#test:device:jetson D457
#test:device:!jetson D455

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets allow all D400 and fix the camera position

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed and changed back to D400*

Comment thread unit-tests/live/image-quality/test-basic-color.py
Comment thread unit-tests/live/image-quality/test-basic-color.py
Comment thread unit-tests/live/image-quality/test-basic-color.py Outdated
"black": (35, 35, 35),
"white": (140, 142, 143),
"gray": (84, 84, 84),
"purple": (56, 52, 78),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this table a bit sensitive? (e.g. blue 8,67,103) ?
Do you check with a tolerance?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, COLOR_TOLERANCE is used when we call is_color_close

@Nir-Az Nir-Az merged commit 3de67da into realsenseai:development Sep 29, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants