Add UYVY to YUYV conversion for D457#14015
Merged
Merged
Conversation
Collaborator
|
suggest to add a test |
Nir-Az
reviewed
May 20, 2025
| } | ||
|
|
||
| std::vector<rs2_format> device::map_supported_color_formats(rs2_format source_format) | ||
| std::vector< rs2_format > device::map_supported_color_formats( rs2_format source_format, bool map_source ) |
Collaborator
There was a problem hiding this comment.
What does map_source means?
Contributor
Author
There was a problem hiding this comment.
The function "maps" a source format to a vector of supported format. The flag indicates if to include the source format in the vector or not. Open to name suggestions :-)
Collaborator
There was a problem hiding this comment.
- why do we need the source?
- If you keep it you can add after the switch
target_formats.push_back(source_format);
instead on each case, right?
Contributor
Author
There was a problem hiding this comment.
- By default (existing implementation) source format is kept and an
identity_processing_blockis created to handle it. In this case we don't want to keep "identity" frames as they are corrupted. We must use another converter to fix them. - For currently supported formats it could have been handled together. In the general case it's not sure. If you want I can change and avoid this small code duplication.
Collaborator
There was a problem hiding this comment.
- on that case I do have a name suggestion, something like "should_convert_raw" or something like this :)
- Your call
Nir-Az
approved these changes
May 21, 2025
OhadMeir
added a commit
to OhadMeir/librealsense
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDSO-20220]