Adding test for be ts after frame ts#13997
Merged
remibettan merged 5 commits intoMay 18, 2025
Merged
Conversation
Nir-Az
reviewed
May 13, 2025
Nir-Az
reviewed
May 13, 2025
| @@ -0,0 +1,98 @@ | |||
| # License: Apache 2.0. See LICENSE file in root directory. | |||
| # Copyright(c) 2024 Intel Corporation. All Rights Reserved. | |||
Nir-Az
reviewed
May 13, 2025
| backend_ts = frame.get_frame_metadata(rs.frame_metadata_value.backend_timestamp) | ||
| delta = backend_ts - frame_ts | ||
| if not test.check(delta > 0): | ||
| print("frame_ts = " + repr(frame_ts) + ", backend_ts = " + repr(backend_ts) + ", delta = " + repr(delta) + ", this should be positive") |
Collaborator
There was a problem hiding this comment.
We will get here on an error?
I think LibCI has some trach method for that no?
Collaborator
There was a problem hiding this comment.
Why not using log.e instead of print?
Nir-Az
reviewed
May 13, 2025
| test.check_equal(int(depth_sensor.get_option(rs.option.global_time_enabled)), 1) | ||
|
|
||
| ############################################################################################# | ||
| with test.closure("Get Depth frame timestamp and compare it to sensor timestamp"): |
Collaborator
There was a problem hiding this comment.
You compare frame timetamp or sensor timestamp?
The title say sensor but the call below is for check_backend_ts_greater_than_frame_ts
Sensor timestamp is another metadata that is not related here right?
Nir-Az
reviewed
May 13, 2025
| test.check_equal(int(color_sensor.get_option(rs.option.global_time_enabled)), 1) | ||
|
|
||
| ############################################################################################# | ||
| with test.closure("Get Color frame timestamp and compare it to sensor timestamp"): |
Nir-Az
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDSO-20166