End recording and start streaming again - bug fix #12534
Merged
Nir-Az merged 3 commits intoDec 24, 2023
Merged
Conversation
Collaborator
|
Tracked by? |
Nir-Az
approved these changes
Dec 24, 2023
Nir-Az
left a comment
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
Looks great!
I will merge but please add the ticket to the description
Collaborator
|
BTW, do you think we can add a UT for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After recording is finished record_device destructor is called. The vector of shared_ptr that points to each record_sensor is cleared but record_sensor isn't destructed.
It is caused because the lambda function in record_device::create_record_sensors calls recording_sensor (shared_ptrlibrealsense::record_sensor) without using weak_ptr.
removed paramaters that are not used inside the function.
Tracked by RSDEV-1226