Skip to content

Participant & liveliness QoS overrides#12448

Merged
maloel merged 4 commits into
realsenseai:developmentfrom
maloel:participant-qos
Dec 3, 2023
Merged

Participant & liveliness QoS overrides#12448
maloel merged 4 commits into
realsenseai:developmentfrom
maloel:participant-qos

Conversation

@maloel

@maloel maloel commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

Allow overriding commonly needed participant settings:

  • participant-id for manual resolving of conflicts (happened in one of our tests)
  • udp/whitelist was asked for, and is especially important with corporate policy disabling multiple adapters
  • lease-duration is currently set at 10 seconds and needs to be overridable
  • liveliness QoS for topic readers/writers

Tracked on [LRS-966]

@maloel maloel requested a review from OhadMeir November 27, 2023 10:30
Comment thread third-party/realdds/src/dds-serialization.cpp Outdated
Comment thread third-party/realdds/src/dds-serialization.cpp
Comment thread third-party/realdds/src/dds-serialization.cpp Outdated
Comment thread third-party/realdds/src/dds-serialization.cpp Outdated

@OhadMeir OhadMeir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit 0bc7512 into realsenseai:development Dec 3, 2023
@maloel maloel deleted the participant-qos branch December 3, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants