revise dds metadata handling with overrides & depth-units#12394
Conversation
| { | ||
| if( auto value = rsutils::json::nested( md, keystr ) ) | ||
| { | ||
| if( value->is_number_integer() ) |
There was a problem hiding this comment.
If we will get something else, don't we want to infrom the user?
There was a problem hiding this comment.
No. This is metadata; we ignore anything we cannot parse.
Same behavior as before -- just doesn't throw exceptions as much (which in Debug mode are constantly triggered).
There was a problem hiding this comment.
Are we getting bad values in debug? DDS layer is supposed to check the message...
There was a problem hiding this comment.
No, the exceptions were when we just didn't find the values for the metadata
| for (auto&& p : s->get_stream_profiles()) | ||
| profiles.push_back(p.get()); | ||
| for( auto const & s : _software_sensors ) | ||
| for( auto const & p : s->_sw_profiles ) |
There was a problem hiding this comment.
Calling get_raw_stream_profiles() is clearer
There was a problem hiding this comment.
It doesn't exist any more :)
There was a problem hiding this comment.
There is get_stream_profiles() or something like it but it returns a vector, not a reference. Since we're a software device and these are software sensors, I elected to access directly.
2 participants
nestedfunctionality inrsutils::json(TS: C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 C0 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR4 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 IR6 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 D2 M8 M8)(TS: C0 D2 IR4 IR6)DLR_Cmatcher, which is also overridable in the settings0.001, without which depth shows up as blackTracked on [LRS-956]