Addressing LRS-462 Viewer IR frames switch#10797
Merged
Merged
Conversation
Collaborator
|
Nice catch ! 1 question , Why did you have to do a merge commit of development and not just rebase and have 1 commit of the actual change? |
maloel
approved these changes
Aug 21, 2022
Nir-Az
approved these changes
Aug 23, 2022
Nir-Az
left a comment
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
Nicely done! Very hard to find BUG 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
model-views post_processing_filters populate viewer::streams_origin to map filtered frames to original streams. Using first_or_default for mapping infrared streams is not always OK.
Changed to using get_infrared_frame(index) when type is RS2_STREAM_INFRARED