ENH: use double-conversion's CMake targets #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
approved these changes
May 23, 2019
This will support multiple system versions of double-conversion. Suggested by Alexander Neumann. Closes InsightSoftwareConsortium#579.
dzenanz
force-pushed
the
cmakeDoubleConversion
branch
from
2823d9a to
a55a394
Compare
Member
Author
|
double-conversion is a library with no dependencies, and it is only privately used in ITK's modules (except remote module Montage, and I am looking into that right now). So we don't have to list it as a public dependency in package configuration file. |
Member
Author
|
... and Montage also privately depends on double-conversion, so I will change the module specification to reflect that. |
thewtex
approved these changes
May 24, 2019
Member
|
@dzenanz Can this be merged? |
Member
Author
|
I am waiting for @TheChymera's confirmation that it fixes the issue it is supposed to address. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will support multiple system versions of double-conversion.
Suggested by Alexander Neumann. Closes #579. Aimed to be back-ported to 4.13.x release to address #912.
PR Checklist