BUG: Fix issue #785 removing BoundingBox check from ImageMask IsInside #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Discussion topic: ImageMaskSpatialObject IsInside less than half a pixel away? |
Added tests for a single zero-valued pixel, and a single non-zero-valued pixel.
Tests if `ImageMaskSpatialObject::IsInside(point)` is independent of the value of distant pixels.
N-Dekker
changed the title
Fixed issue #785 (ImageMaskSpatialObject IsInside should not depend on distant pixels) by removing the BoundingBox check from `ImageMask::IsInsideInObjectSpace`. It appears that the computed bounding box is too small to recognize all points whose interpolated pixel value is non-zero as being inside. The run-time duration might become either slightly longer or slightly shorter, depending on the image. In practice, the performance effect of this commit appears very small (in either way).
aylward
approved these changes
May 6, 2019
Member
aylward
left a comment
aylward
left a comment
There was a problem hiding this comment.
Interesting - never though about skipping the bounding box check for mask images and going straight to pixel-level checking. Seems fine to me for this kind of object. Go for it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #785 (ImageMaskSpatialObject IsInside should not depend on
distant pixels) by removing the BoundingBox check from
ImageMask::IsInsideInObjectSpaceAdded various GTest unit tests for
ImageMaskSpatialObject::IsInside