allow to bypass API failure and still init a connection#294
allow to bypass API failure and still init a connection#294
Conversation
tfardet
left a comment
tfardet
left a comment
There was a problem hiding this comment.
It looks OK apart from a small question I have on seemingly unrelated change.
I don't think we can test these on GH so I'll run them locally before merging
|
I hadn't had the time yet to check what happened in the test log failure, so maybe don't merge it right away. I suspect there might be some changes to be done still. |
|
@tgrandje should I check it now or are you still working on it? if so, just ping me when I should review and test it |
|
Still on it 🙂 . There's still something to be done to patch the connection test during the test jobs. I had a run yesterday evening but that hadn't work very well... I'll ping you when it is ready. |
|
And that one's good for review now 🙂 |
|
sorry, I'm a bit swamped at the moment, I'll try to review your PRs during the week-end, please ping me next week if I haven't reviewed them ;) |
|
No pressure, the right time to work on this is when you got it 😉 (I've had a tiny bit less work these past few days, I'm using it) |
2 participants
#290
Allow to bypass failure on API A (because of server errors) when querying API B.