Conversation
Asserts that the beacon node follower can sync blobs during initial-sync. This patch also refactors the test harness to accommodate dynamic nodes.
… Lodestar pre-4844 test in CI
dgcoffman
commented
Nov 10, 2022
Inphi
reviewed
Nov 10, 2022
Owner
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
The erigon submodule is deleted. Is this intentional?
Collaborator
pls don't delete! |
Collaborator
Author
Nope |
Inphi
reviewed
Nov 11, 2022
Owner
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
LGTM. Should we add lodestar to the CI tests?
Owner
|
I don't expect the post-4844 tests to pass since we dont' yet have an updated execution client. But we can at least add the pre-4844 tests to CI. |
Collaborator
Author
dgcoffman
commented
Nov 11, 2022
| - '5778:5778' | ||
| - '16686:16686' | ||
| - '14268:14268' | ||
| - '9411:9411' |
Collaborator
Author
There was a problem hiding this comment.
I'm sorry, my editor wants single quotes real bad 🤷♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
go run ./tests/...tests all passgo run ./tests/pre-4844 lodestarpasses