Skip to content

add BLST_PORTABLE to CGO_CFLAGS to fix SIGILL issue with blst #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roberto-bayardo merged 1 commit into from
Nov 7, 2022
Merged

add BLST_PORTABLE to CGO_CFLAGS to fix SIGILL issue with blst #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: CI

# The flag below may be needed if blst throws SIGILL, which happens with certain (older) CPUs
env:
CGO_CFLAGS: "-O -D__BLST_PORTABLE__"

on:
push:
branches: [ "master", "devnet-v3" ]
Expand Down
1 change: 1 addition & 0 deletions geth/Dockerfile.geth
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ WORKDIR /app/go-ethereum

# The flag below may be needed if blst throws SIGILL, which happens with certain (older) CPUs
# ENV CGO_CFLAGS="-O -D__BLST_PORTABLE__"
ENV CGO_CFLAGS=$CGO_CFLAGS

# Build directly as make geth doesn't work because it expects a normal git repository rather than a submodule. We set -buildvcs directly here to avoid this
RUN go build \
Expand Down
1 change: 1 addition & 0 deletions prysm/Dockerfile.prysm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ WORKDIR /app/prysm

# The flag below may be needed if blst throws SIGILL, which happens with certain (older) CPUs
# ENV CGO_CFLAGS="-O -D__BLST_PORTABLE__"
ENV CGO_CFLAGS=$CGO_CFLAGS

RUN go build -o /build/beacon-node -buildvcs=false ./cmd/beacon-chain
RUN go build -o /build/validator -buildvcs=false ./cmd/validator
Expand Down