Switch to downloading blobs from the Prysm RPC API#34
Switch to downloading blobs from the Prysm RPC API#34mdehoog wants to merge 4 commits intoInphi:masterfrom
Conversation
|
One thought though: would we want to keep both approaches for more thorough testing? Or is most of that removed code duplicating what's now in the Prysm RPC API? |
|
The removed code isn't duplicating the RPC API. I think we should keep and test both approaches. The We can still merge this PR, as I'd be glad to get rid of that code, but only if we add a new test scenario that asserts p2p RPC works. For example, we setup a test with a late |
|
This was implemented via #44, which also adds a historical sync e2e test so we don't lose test coverage. Closing. |
No description provided.