-
Notifications
You must be signed in to change notification settings - Fork 202
Improve contribution pathway #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
spier
merged 8 commits into
InnerSourceCommons:main
from
jeffabailey:improve-contribution-pathway
Nov 7, 2025
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2bfa32e
feat: add reciprocal links to AI draft and contrib
jeffabailey 5b007c1
Change numbering
spier c557b3d
Change numbering
spier 9467576
chore: merge new pattern bullets
jeffabailey 0d4ea3a
Merge branch 'improve-contribution-pathway' of github.com:jeffabailey…
jeffabailey 433c482
Merge branch 'InnerSourceCommons:main' into improve-contribution-pathway
jeffabailey 492981a
chore: remove blank line
jeffabailey 0558c47
chore: remove typo
jeffabailey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffabailey I am not sure what you mean by "with m basic writing style conventions".
I guess the "m" in there is a typo for sure. ;)
The real definition of a Donut pattern is pattern with out a Solution (i.e. a hole in the middle).
However maybe we should leave that whole internal language away as nobody understands it anyways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, typo for sure. :)
I removed the donut pattern description. I agree, it's confusing.
We may benefit from some pattern structure linting at some point to help prevent donut patterns.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffabailey we have a linter for the pattern structure already. However we only apply it to maturity level Structured. i.e. for Draft patterns the authors can do whatever they want really (on purpose).