Feature: mongodb secret rotation #4889

victorvhs017 · 2025-11-18T00:06:21Z

Description 📣

Add Mongodb app connection and secret rotation to Infisical with their respective documentation.

Type ✨

Tests 🛠️

Test the mongodb app connection
Test with and with SSL
Test with regular mongo URI and mongodb+srv URIs
Check the app connection documentation
Test the mongodb secret rotation
Test with and with SSL
Test with regular mongo URI and mongodb+srv URIs
Check the secret rotation documentation

I have read the contributing guide, agreed and acknowledged the code of conduct. 📝

- Introduced MongoDB connection router and schemas. - Updated app connection enums and maps to include MongoDB. - Implemented validation and connection functions for MongoDB. - Enhanced app connection service to handle MongoDB credentials.

- Implemented MongoDB connection form with validation and credential handling. - Updated enums and maps to include MongoDB support across backend and frontend. - Enhanced app connection schemas to accommodate MongoDB connection options. - Integrated MongoDB connection handling in relevant components and hooks.

- Enhanced MongoDB connection handling in backend with improved host validation. - Updated documentation to include MongoDB connection options and API references. - Added new images for MongoDB connection forms and processes. - Implemented MongoDB connection form in the frontend with necessary adjustments.

- Introduced MongoDB credentials rotation router and schemas. - Updated backend services to handle MongoDB credentials rotation logic. - Enhanced frontend components to support MongoDB credentials management. - Integrated MongoDB credentials rotation into existing secret rotation options and forms.

maidul98 · 2025-11-18T00:07:00Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

greptile-apps · 2025-11-18T00:09:26Z

Greptile Summary

Adds MongoDB connection support with username/password authentication, SSL/TLS configuration, and URL normalization for both standard and SRV connection strings
Implements secret rotation for MongoDB credentials using dual-user pattern (username1/username2) with password updates via updateUser command
Includes comprehensive documentation with user setup instructions, permission requirements, and UI/API configuration examples

Confidence Score: 3/5

This PR introduces regex usage that violates repository security policy requiring re2 for ReDoS prevention
The MongoDB feature implementation is solid with proper host validation via verifyHostInputValidity and good authorization patterns. However, two critical files use native JavaScript regex (.replace() with regex literals) instead of the required re2 package, creating potential ReDoS attack vectors. This violates Rule 1 from repository guidelines.
Fix native regex usage in backend/src/services/app-connection/mongodb/mongodb-connection-fns.ts and backend/src/ee/services/secret-rotation-v2/mongodb-credentials/mongodb-credentials-rotation-fns.ts before merging

Important Files Changed

Filename	Overview
backend/src/services/app-connection/mongodb/mongodb-connection-fns.ts	Adds MongoDB connection validation with host/URL normalization, but uses native regex which needs replacement with re2 to prevent ReDoS
backend/src/ee/services/secret-rotation-v2/mongodb-credentials/mongodb-credentials-rotation-fns.ts	Implements MongoDB credentials rotation with password updates, but uses native regex which needs replacement with re2 to prevent ReDoS

greptile-apps

_{50 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}
_{React with 👍 or 👎 to share your feedback on this new summary format}

backend/src/services/app-connection/mongodb/mongodb-connection-fns.ts

...d/src/ee/services/secret-rotation-v2/mongodb-credentials/mongodb-credentials-rotation-fns.ts

- Replaced string methods with RE2 regex for improved host validation in MongoDB connection functions. - Updated the `mongodbCredentialsRotationFactory` and `validateMongoDBConnectionCredentials` to utilize regex for parsing connection strings. - Enhanced code readability and maintainability by consolidating host normalization logic.

- Created comprehensive documentation for MongoDB credentials rotation, detailing setup and usage. - Added new images to illustrate the MongoDB credentials rotation process in the UI. - Updated existing documentation to include MongoDB in the secret rotation options and API references.

scott-ray-wilson

Looking good overall! few nits and comments

scott-ray-wilson · 2025-11-21T01:01:10Z

docs/docs.json

                      "documentation/platform/secret-rotation/ldap-password",
                      "documentation/platform/secret-rotation/mssql-credentials",
                      "documentation/platform/secret-rotation/mysql-credentials",
+                      "documentation/platform/secret-rotation/mongodb-credentials",


nit: bump above mysql for alpha sorting

scott-ray-wilson · 2025-11-21T01:31:46Z

docs/documentation/platform/secret-rotation/mongodb-credentials.mdx

+                "environment": {
+                    "slug": "dev",
+                    "name": "Development",
+                    "id": ""170a40f1-1b48-4cc7-addf-e563aa9fbe37"


nit: double quotes in front of uuid ""170...

scott-ray-wilson · 2025-11-21T01:32:17Z

docs/documentation/platform/secret-rotation/mongodb-credentials.mdx

+                },
+                "projectId": "3c90c3cc-0d44-4b50-8888-8dd25736052a",
+                "folder": {
+                    "id": ""b3257e1f-8d32-4e86-8bfd-b1f1bc1bf2c3"",


same here double wrapped quotes

scott-ray-wilson · 2025-11-21T02:31:48Z

...d/src/ee/services/secret-rotation-v2/mongodb-credentials/mongodb-credentials-rotation-fns.ts

+
+    let client: MongoClient | null = null;
+    try {
+      client = await $getClient();


for both issue and revoke I think we want to use a mongodb session (transaction) - that way if either command fails neither commits

scott-ray-wilson · 2025-11-21T02:34:12Z

backend/src/services/app-connection/mongodb/mongodb-connection-fns.ts

If I misconfigure any of the fields that lead to an invalid connection I just eventually timeout and get an undefined error

Victor Santos added 4 commits November 14, 2025 20:26

Add MongoDB connection support

8121db6

- Introduced MongoDB connection router and schemas. - Updated app connection enums and maps to include MongoDB. - Implemented validation and connection functions for MongoDB. - Enhanced app connection service to handle MongoDB credentials.

mintlify bot deployed to staging - docs November 18, 2025 00:08 View deployment

greptile-apps bot reviewed Nov 18, 2025

View reviewed changes

backend/src/services/app-connection/mongodb/mongodb-connection-fns.ts Outdated Show resolved Hide resolved

...d/src/ee/services/secret-rotation-v2/mongodb-credentials/mongodb-credentials-rotation-fns.ts Outdated Show resolved Hide resolved

Victor Santos added 3 commits November 17, 2025 22:36

Merge branch 'main' into feature/mongodb-secret-rotation

406f0a1

mintlify bot deployed to staging - docs November 18, 2025 18:57 View deployment

mintlify bot deployed to staging - docs November 18, 2025 18:59 View deployment

refactor: remove unused import from index.ts

58a5688

victorvhs017 requested a review from scott-ray-wilson November 18, 2025 20:33

Merge branch 'main' into feature/mongodb-secret-rotation

c01444d

mintlify bot deployed to staging - docs November 19, 2025 17:15 View deployment

Victor Santos added 2 commits November 20, 2025 19:29

Merge branch 'main' into feature/mongodb-secret-rotation

06fb205

fix: correct host normalization logic in MongoDB connection functions

4ed75e3

mintlify bot deployed to staging - docs November 20, 2025 23:03 View deployment

scott-ray-wilson requested changes Nov 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature: mongodb secret rotation #4889

Feature: mongodb secret rotation #4889

Uh oh!

victorvhs017 commented Nov 18, 2025 •

edited

Loading

Uh oh!

maidul98 commented Nov 18, 2025 •

edited

Loading

Uh oh!

greptile-apps bot commented Nov 18, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

scott-ray-wilson left a comment

Uh oh!

scott-ray-wilson Nov 21, 2025

Uh oh!

scott-ray-wilson Nov 21, 2025

Uh oh!

scott-ray-wilson Nov 21, 2025

Uh oh!

scott-ray-wilson Nov 21, 2025

Uh oh!

scott-ray-wilson Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Feature: mongodb secret rotation #4889

Are you sure you want to change the base?

Feature: mongodb secret rotation #4889

Uh oh!

Conversation

victorvhs017 commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📣

Type ✨

Tests 🛠️

Uh oh!

maidul98 commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

greptile-apps bot commented Nov 18, 2025

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

scott-ray-wilson left a comment

Choose a reason for hiding this comment

Uh oh!

scott-ray-wilson Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

scott-ray-wilson Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

scott-ray-wilson Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

scott-ray-wilson Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

scott-ray-wilson Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

victorvhs017 commented Nov 18, 2025 •

edited

Loading

maidul98 commented Nov 18, 2025 •

edited

Loading