Skip to content

feat(cli): allow using project name to resolve project ID (#2594) #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(cli): allow using project name to resolve project ID (#2594) #4857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions backend/src/services/project/project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1976,9 +1976,48 @@ export const projectServiceFactory = ({
});
};

const getProjectByName = async ({
name,
actor,
actorId,
actorOrgId,
actorAuthMethod
}: {
name: string;
actor: ActorType;
actorId: string;
actorOrgId: string;
actorAuthMethod: ActorAuthMethod;
}) => {
const project = await projectDAL.findOne({ name, orgId: actorOrgId });
Copy link
Contributor

@greptile-apps greptile-apps bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: project names are not unique within an org - multiple projects can share the same name. Using findOne with just name and orgId may return an arbitrary project if duplicates exist, potentially granting access to the wrong project. This is a critical security issue.

Verify project name uniqueness constraints in schema, or use slug instead (which is unique).

if (!project) {
throw new NotFoundError({
message: `Project with name '${name}' not found`
});
}

const { permission } = await permissionService.getProjectPermission({
actor,
actorId,
projectId: project.id,
actorAuthMethod,
actorOrgId,
actionProjectType: ActionProjectType.Any
});

ForbiddenError.from(permission).throwUnlessCan(
ProjectPermissionActions.Read,
ProjectPermissionSub.Project
);

return project;
};


return {
createProject,
deleteProject,
getProjectByName,
getProjects,
updateProject,
getProjectUpgradeStatus,
Expand Down