Implement option for expandSecretsReferences parameter in api call#6
Open
svr333 wants to merge 2 commits intoInfisical:mainfrom
Open
Implement option for expandSecretsReferences parameter in api call#6svr333 wants to merge 2 commits intoInfisical:mainfrom
svr333 wants to merge 2 commits intoInfisical:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to use expandSecretsReferences.
See #5.
Note
It currently defaults to true, which is what it should be in my opinion, but the default in the api itself is false.
To me it makes more sense to default this to true everywhere, however it is understandable if you'd rather default to false.
I also removed some unused using statements I came across.
Other
Resolves #5