Stopwatch - Extend button touch area #558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
50 might be too much. If people get used to this extremely oversized active area, and it turns out it has to be shrinked, people wouldn't like that. This is why I made it a safe 10px in the other PR. This app could also be redesigned to start and stop on tapping the background for example. I think we should look at alternative solutions before extending the area on any button. |
Contributor
|
This may cause accidental presses with #612 |
1 task
Contributor
|
The stopwatch UI has been updated, obsoleting this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can touch up to 50 px above the button and it still gets recognized as a touch.