Skip to content

Conversation

@Elements6007
Copy link
Contributor

@Elements6007 Elements6007 commented Oct 23, 2022

This PR combines SettingSetTime and SettingSetDate into one setting app(SettingSetDateTime). I thought it would be nice to combine the two settings because it would put both in the same place and there would be one less setting in the setting menu. I hope you guys like it!

Note: I know that it does not work with InfiniSim because of the name change.

0017-0697_Trim.mp4

Thanks!

@LinuxinaBit
Copy link

LinuxinaBit commented Oct 24, 2022

Very nice idea and good implementation.
The only problem with this is mostly just that the user might not even realize it exists.
A good case study of this is the music app, did you know it has volume control? It took me a few months to figure that out, and many people still don’t realize it exists…

@Elements6007
Copy link
Contributor Author

Very nice idea and good implementation. The only problem with this is mostly just that the user might not even realize it exists. A good case study of this is the music app, did you know it has volume control? It took me a few months to figure that out, and many people still don’t realize it exists…

Thanks for your input, but in my opinion the side indicators(i think my fingers were in the way in the video) hint to the second page adequately where as the music app has no such indicators. However, if others agree this is a problem then i will close the PR.

20221024_140720 (Small)

^better pic of indicator

@LinuxinaBit
Copy link

Ah, ok, sorry I didn’t see that. Along with the title “Date & Time” it actually makes more sense to group them in a way… Very nice :)

@Elements6007 Elements6007 deleted the Combine-SettingSetTime-w/-SettingSetDate branch October 25, 2022 15:41
@Elements6007 Elements6007 restored the Combine-SettingSetTime-w/-SettingSetDate branch October 25, 2022 15:41
@Elements6007 Elements6007 deleted the Combine-SettingSetTime-w/-SettingSetDate branch October 25, 2022 15:43
@Elements6007 Elements6007 restored the Combine-SettingSetTime-w/-SettingSetDate branch October 25, 2022 15:44
@Elements6007
Copy link
Contributor Author

Elements6007 commented Oct 25, 2022

Sorry about that, I was trying to rename the branch because the "/" character in the branch name caused the firmware build to fail, I did not know that renaming a branch would remove the PR. So looks like i have to make a new PR? is anyone still interested?

@Elements6007
Copy link
Contributor Author

Closing #1465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants