Skip to content

Conversation

@YuryHrytsuk
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk commented Nov 11, 2025

What do these changes do?

Configure traefik via environment variables. This lets developers updating traefik configuration by changing ENV in portainer. Previous approach required redeploying simcore stack (not convenient). Use case: enable access and debug logs on prod to investigate some issue.

FYI @sanderegg @matusdrobuliak66 @GitHK to trace ITISFoundation/osparc-ops-environments#1253 we need to enable logs and check for errors. This is the "solution" as of now

Related issue/s

Related PR/s

How to test

deploy locally and ensure all works normally

Dev-ops ⚠️

Checks

  • check ops and simcore traefik dashboard and see of all routers are green
  • check ops and simcore traefik logs
  • start different services and see if all manage to start
  • check postgres / redis routers work properly

It makes traefik configuration adjustments easier. One can do that by
changing ENV in portainer. Use case: enable access and debug logs on
prod to investigate some issue

Related issues
* ITISFoundation/osparc-ops-environments#1253

Related PR/s
* ... corresponding changes in OPS must be added
@YuryHrytsuk YuryHrytsuk added this to the Imparable milestone Nov 11, 2025
@YuryHrytsuk YuryHrytsuk self-assigned this Nov 11, 2025
@YuryHrytsuk YuryHrytsuk added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Nov 11, 2025
@YuryHrytsuk YuryHrytsuk changed the title ♻️ traefik: configure via env not command ⚠️ ♻️ traefik: configuration via environment variables ⚠️ Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.56%. Comparing base (8679c75) to head (aa36488).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8572   +/-   ##
=======================================
  Coverage   87.55%   87.56%           
=======================================
  Files        2012     2012           
  Lines       79025    79025           
  Branches     1368     1368           
=======================================
+ Hits        69191    69196    +5     
+ Misses       9428     9423    -5     
  Partials      406      406           
Flag Coverage Δ
integrationtests 63.89% <ø> (+<0.01%) ⬆️
unittests 86.28% <ø> (-0.02%) ⬇️
Components Coverage Δ
pkg_aws_library 94.98% <ø> (ø)
pkg_celery_library 83.22% <ø> (ø)
pkg_dask_task_models_library 79.37% <ø> (ø)
pkg_models_library 92.90% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.99% <ø> (ø)
pkg_service_integration 72.76% <ø> (ø)
pkg_service_library 71.00% <ø> (ø)
pkg_settings_library 90.29% <ø> (ø)
pkg_simcore_sdk 84.95% <ø> (ø)
agent 93.10% <ø> (ø)
api_server 91.35% <ø> (ø)
autoscaling 95.83% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 91.72% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 90.85% <ø> (+0.01%) ⬆️
dynamic_scheduler 96.66% <ø> (ø)
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.11% <ø> (-0.22%) ⬇️
storage 86.92% <ø> (+0.28%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.05% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8679c75...aa36488. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

YuryHrytsuk added a commit to YuryHrytsuk/osparc-ops-environments that referenced this pull request Nov 11, 2025
Configure simcore traefik via env (instead of commands). This makes
configuration adjustments easier (it can be done on-the-fly via
portainer). Use case: enable access and debug logs on PROD to
investigate issues

Related PR/s
* ITISFoundation/osparc-simcore#8572
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! thanks!

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2025

🧪 CI Insights

Here's what we observed from your CI run for aa36488.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests You had a 43% chance of failing… lucky you! 🎲 Flaky Configure an automatic retry View View

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! 🎈

Converting commands to env variables have implication. Names that have
underscore inside cannot be converted to env variables without a change
(underscore has special meaning). See more traefik/traefik#5427

Fix the problem by removing underscore.

Traefik error log
```
failed to decode configuration from environment variables: field not found, node: api
```
@sonarqubecloud
Copy link

@YuryHrytsuk YuryHrytsuk merged commit 0792d8a into ITISFoundation:master Nov 11, 2025
94 checks passed
@YuryHrytsuk YuryHrytsuk deleted the configure-traefik-via-env branch November 11, 2025 10:23
YuryHrytsuk added a commit to ITISFoundation/osparc-ops-environments that referenced this pull request Nov 11, 2025
* simcore traefik: configuration via env

Configure simcore traefik via env (instead of commands). This makes
configuration adjustments easier (it can be done on-the-fly via
portainer). Use case: enable access and debug logs on PROD to
investigate issues

Related PR/s
* ITISFoundation/osparc-simcore#8572

* Update simcore api entrypoint name

Accroding to ITISFoundation/osparc-simcore@ff12cac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:infra+ops maintenance of infrastructure or operations (discussed in retro)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Traefik forwardauth middleware "silently" fails if wb-auth server is down / not reachable

4 participants