-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ traefik: configuration via environment variables ⚠️ #8572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ traefik: configuration via environment variables ⚠️ #8572
Conversation
It makes traefik configuration adjustments easier. One can do that by changing ENV in portainer. Use case: enable access and debug logs on prod to investigate some issue Related issues * ITISFoundation/osparc-ops-environments#1253 Related PR/s * ... corresponding changes in OPS must be added
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8572 +/- ##
=======================================
Coverage 87.55% 87.56%
=======================================
Files 2012 2012
Lines 79025 79025
Branches 1368 1368
=======================================
+ Hits 69191 69196 +5
+ Misses 9428 9423 -5
Partials 406 406
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Configure simcore traefik via env (instead of commands). This makes configuration adjustments easier (it can be done on-the-fly via portainer). Use case: enable access and debug logs on PROD to investigate issues Related PR/s * ITISFoundation/osparc-simcore#8572
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! thanks!
🧪 CI InsightsHere's what we observed from your CI run for aa36488. ✅ Passed Jobs With Interesting Signals
|
mrnicegyu11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! 🎈
Converting commands to env variables have implication. Names that have underscore inside cannot be converted to env variables without a change (underscore has special meaning). See more traefik/traefik#5427 Fix the problem by removing underscore. Traefik error log ``` failed to decode configuration from environment variables: field not found, node: api ```
|
* simcore traefik: configuration via env Configure simcore traefik via env (instead of commands). This makes configuration adjustments easier (it can be done on-the-fly via portainer). Use case: enable access and debug logs on PROD to investigate issues Related PR/s * ITISFoundation/osparc-simcore#8572 * Update simcore api entrypoint name Accroding to ITISFoundation/osparc-simcore@ff12cac



What do these changes do?
Configure traefik via environment variables. This lets developers updating traefik configuration by changing ENV in portainer. Previous approach required redeploying simcore stack (not convenient). Use case: enable access and debug logs on prod to investigate some issue.
FYI @sanderegg @matusdrobuliak66 @GitHK to trace ITISFoundation/osparc-ops-environments#1253 we need to enable logs and check for errors. This is the "solution" as of now
Related issue/s
wb-authserver is down / not reachable osparc-ops-environments#1253 --> we need to enable traefik debug logs to trace this issue. With changes from this PR it will be easyRelated PR/s
How to test
deploy locally and ensure all works normally
Dev-ops⚠️
Checks