Skip to content

Maintenance: review and cleanup python formatting & static analysis tooling #2731

@pcrespov

Description

@pcrespov

common.Makefile has multiple recipes addressing code formatting and analysis that have overlapping functionality, namely:

  • make autoformat: runs isort and black
  • make codestyle/ codestyle-ci:
    • runs scripts/codestyle.bash
      • runs isort, black, pylint and mypy
    • used also in ci (should not call make from CI!)
  • make code-analysis:
    • runs scripts/code-climate
      • docker run's codeclimate
  • make mypy
    • runs scripts/mypy.bash
      - docker runs mypy

See issue #2811 because we do not have in place a static-analysis in CI

Metadata

Metadata

Assignees

Labels

t:maintenanceSome planned maintenance work

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions