Skip to content

finishing library migration#5

Merged
Thermadiag merged 4 commits intomainfrom
fix-librir-migration
May 23, 2023
Merged

finishing library migration#5
Thermadiag merged 4 commits intomainfrom
fix-librir-migration

Conversation

@dubusster
Copy link
Contributor

No description provided.

@dubusster dubusster requested review from Thermadiag and egrelier May 17, 2023 08:51
@dubusster dubusster self-assigned this May 17, 2023
@dubusster dubusster added bug Something isn't working help wanted Extra attention is needed labels May 17, 2023
@github-actions
Copy link

github-actions bot commented May 17, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
build\install\librir\geometry\__init__.py550%1–17
build\install\librir\low_level\misc.py711677%41–44, 58–59, 68, 73–78, 83–88
build\install\librir\low_level\rir_geometry.py948411%16–46, 53–87, 95–120, 134–164, 176–218, 227–260, 273–301
build\install\librir\low_level\rir_signal_processing.py2412257%19–189, 197–220, 227–254, 265–314, 327–390, 399–408, 415, 422–436, 443–467, 474–487, 499–581, 591–666
build\install\librir\low_level\rir_tools.py22713341%20–21, 29–48, 56–78, 86–109, 117–139, 149, 165–166, 173–176, 183, 191, 198–204, 231, 261, 268–297, 301–330, 334–341, 349, 356, 361, 365–368, 372–423, 430, 449, 453, 456–459, 478
build\install\librir\low_level\rir_video_io.py37721942%36, 44–47, 68–73, 82, 108, 127, 145, 154, 183, 195–198, 206–213, 218–223, 228–236, 241–244, 252–255, 264–267, 272–273, 281–284, 289–290, 295–298, 305, 314–323, 330–332, 339–357, 384–386, 395, 425–427, 436, 451, 456, 479, 492–507, 522, 533, 574, 582–625, 633–639, 647–669, 677–699, 707–735, 751–769, 776, 783–790, 797–804, 811–816, 823–830
build\install\librir\registration\compute_registration.py1381380%8–320
build\install\librir\registration\masked_registration_ecc.py1061060%2–212
build\install\librir\registration\registration_thermavip.py15150%1–22
build\install\librir\signal_processing\BadPixels.py9367%22, 25, 28
build\install\librir\tools\FileAttributes.py651971%72–73, 80–82, 91, 94, 100, 103, 110, 116, 133–139, 145
build\install\librir\tools\utils.py1038220%24–87, 91–97, 101–102, 106, 110–121, 125–126, 130–135, 139–154, 158–166, 170–174, 179–184
build\install\librir\video_io\IRMovie.py46015666%136, 145, 197–198, 226–229, 240, 244–248, 255–257, 266, 269, 281–284, 298–306, 310, 328–337, 341, 345–346, 354–358, 374, 387, 391, 419, 428, 432, 436–438, 442–444, 448–450, 454–456, 465–472, 478, 481, 490–505, 508–509, 512, 525, 529–531, 537, 549, 553–566, 618–620, 645, 649, 653, 657–659, 665–671, 675, 680, 685, 690–696, 699–705, 711, 717, 723, 729, 733, 740–742, 746, 750, 754, 758–762, 765–780
build\install\librir\video_io\IRSaver.py651478%106, 108–109, 131, 141, 152, 160–169, 175–184, 187, 190
build\install\librir\video_io\utils.py392828%23–44, 48–49, 58–64
TOTAL2049124339%
 

Tests Skipped Failures Errors Time
92 0 💤 0 ❌ 0 🔥 4.238s ⏱️

@dubusster
Copy link
Contributor Author

There are some issues with python tests for IRMovie generated from numpy arrays of shapes (10, 515, 640) and (10, 243, 320).
The issue seems to reside in the C part with an access violation : OSError: exception: access violation reading 0x0000000000000000

This occurs everytime the second image of the instantiated movie is called by the C function rir_video_io.load_image

Can you have a look @Thermadiag ? It might be nothing or related to my computer but it crashes everytime...

@dubusster dubusster force-pushed the fix-librir-migration branch 2 times, most recently from f92d1cf to 7c7fa1c Compare May 22, 2023 10:07
egrelier
egrelier previously approved these changes May 23, 2023
egrelier

This comment was marked as duplicate.

@egrelier egrelier dismissed their stale review May 23, 2023 06:58

Waiting for @Thermadiag's input.

@Thermadiag Thermadiag merged commit 1f06e35 into main May 23, 2023
@Thermadiag Thermadiag deleted the fix-librir-migration branch May 23, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

access violation : OSError: exception: access violation reading 0x0000000000000000

3 participants