-
-
Notifications
You must be signed in to change notification settings - Fork 16
Revert previous attempt at Triton patch; use CustomCacheManger approach instead. #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aef43e2
Revert previous attempt at Triton patch; use CustomCacheManger instead.
tdoublep d5910bb
Remove existing patch file.
tdoublep ed54561
Fix for ruff
tdoublep cf4eae9
Fix for isort
tdoublep 4c5c1e7
Small updates from review
joerunde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import os | ||
|
|
||
| from triton.runtime.cache import (FileCacheManager, default_cache_dir, | ||
| default_dump_dir, default_override_dir) | ||
|
|
||
|
|
||
| class CustomCacheManager(FileCacheManager): | ||
|
|
||
| def __init__(self, key, override=False, dump=False): | ||
| self.key = key | ||
| self.lock_path = None | ||
| if dump: | ||
| self.cache_dir = default_dump_dir() | ||
| self.cache_dir = os.path.join(self.cache_dir, self.key) | ||
| self.lock_path = os.path.join(self.cache_dir, "lock") | ||
| os.makedirs(self.cache_dir, exist_ok=True) | ||
| elif override: | ||
| self.cache_dir = default_override_dir() | ||
| self.cache_dir = os.path.join(self.cache_dir, self.key) | ||
| else: | ||
| # create cache directory if it doesn't exist | ||
| self.cache_dir = os.getenv("TRITON_CACHE_DIR", | ||
| "").strip() or default_cache_dir() | ||
| self.cache_dir = self.cache_dir + "_" + str(os.getpid()) | ||
| print(f"{self.cache_dir=}") | ||
njhill marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if self.cache_dir: | ||
| self.cache_dir = os.path.join(self.cache_dir, self.key) | ||
| self.lock_path = os.path.join(self.cache_dir, "lock") | ||
| os.makedirs(self.cache_dir, exist_ok=True) | ||
| else: | ||
| raise RuntimeError("Could not create or locate cache dir") | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.