Skip to content

Comments

fix: non-flexible ElectLeadersRequest V0/V1 encode/decode#3312

Merged
hindessm merged 1 commit intoIBM:mainfrom
hindessm:fix-elect-leaders-request-v1
Sep 26, 2025
Merged

fix: non-flexible ElectLeadersRequest V0/V1 encode/decode#3312
hindessm merged 1 commit intoIBM:mainfrom
hindessm:fix-elect-leaders-request-v1

Conversation

@hindessm
Copy link
Collaborator

And clean up the misleading layout/comment of the []bytes in the test:

Test layout for V2 []byte was:

	0, 0, // empty tagged fields
	0, 39, 16, 0, // timeout 10000

but, while the bytes were correct the comments were misleading as the encoding is really:

	0,            // empty tagged fields
	0, 0, 39, 16, // timeout 10000
	0, // empty tagged fields

And clean up the misleading layout/comment of the []bytes in the test

Signed-off-by: beanz <mark.hindess@gmail.com>
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@dnwe
Copy link
Collaborator

dnwe commented Sep 26, 2025

Aside: we probably should have a functional test for elect leaders as I feel like this has likely never properly worked?

@hindessm hindessm merged commit 8381c03 into IBM:main Sep 26, 2025
16 checks passed
@hindessm hindessm deleted the fix-elect-leaders-request-v1 branch September 26, 2025 11:08
@dnwe dnwe added the fix label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants