Merged
Conversation
Dependencies are all starting to move to go 1.23.0 going forwards, so we'll sadly have to start bumping Sarama's go directive more aggressively as well in order to keep up. The Go maintainers have unfortunately decided that: > A module’s go line must declare a version greater than or equal to the > go version declared by each of the modules listed in require > statements. and > Before Go 1.21, Go toolchains treated the go line as an advisory > requirement: if builds succeeded the toolchain assumed everything > worked, and if not it printed a note about the potential version > mismatch. Go 1.21 changed the go line to be a mandatory requirement > instead. So we really have no option here, especially with the golang.org/x modules bumping to 1.23.0 as soon as 1.24.0 was released, we can no longer continue to support older Go toolchains. Also bump CI testing to use the "oldstable" and "stable" aliases for N-1 and N going forwards as we're unlikely to want to test with anything else. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
Signed-off-by: Dominic Evans <8060970+dnwe@users.noreply.github.com>
dnwe
force-pushed
the
dnwe/bump-minimum-go
branch
from
ab675c1 to
4343972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies are all starting to move to go 1.23.0 going forwards, so we'll sadly have to start bumping Sarama's go directive more aggressively as well in order to keep up. The Go maintainers have unfortunately decided that:
and
So we really have no option here, especially with the golang.org/x modules bumping to 1.23.0 as soon as 1.24.0 was released, we can no longer continue to support older Go toolchains.
Also bump CI testing to use the "oldstable" and "stable" aliases for N-1 and N going forwards as we're unlikely to want to test with anything else.