feat: expose IncrementalAlterConfigs API in admin.go#2088
Conversation
|
Thanks @fengyinqiao — these changes look reasonable to me, a good extension to expose the functionality added under #1966 — thanks for doing this PR Please can you check on the CLA? Have you signed it with an email address that matches your GitHub username? |
|
@dnwe I didn't expect you to reply so quickly. Thank you so much!!! And I have signed the CLA, but why is it still a problem?How can I re-run the CLA check? |
|
@fengyinqiao I have re-run it, I think the problem is that your author email address in the commit is [email protected] but that email address doesn’t seem to be associated with your GitHub account so it’s not getting tracked |
|
@dnwe Sorry, that's my company email address for work. I didn't notice that... I can't use this email address to sign again, because my Github user name has already been signed, may I ask how to solve it? |
|
@fengyinqiao you can either add that email address as another contact address on this account, or you can “git commit —amend —reset-author” after changing your local git config to an email address that matches this GH account and then force push to your PR branch |
@dnwe I have already added this email address to my GitHub account =_=, could you please run it again? |
|
Yep that’s passing now 🎉 |
|
@dnwe Once again, I would like to express my sincere thanks to you, for your so so so quick reply 🎉🎉🎉 |
|
@dnwe May I ask if this PR can be merged? |
For #2083