fix: stuck on the batch with zero records length#2057
Merged
Conversation
ghost
added
the
pachmu
force-pushed
the
fix-empty-batch-consume
branch
from
583da58 to
a8a9228
Compare
dnwe
approved these changes
Nov 6, 2021
Collaborator
dnwe
left a comment
dnwe
left a comment
There was a problem hiding this comment.
Thanks, this looks like a great catch
bai
approved these changes
Nov 8, 2021
1 task
dnwe
added a commit
that referenced
this pull request
Jul 31, 2025
This pull request addresses the known issue described in [KAFKA-5443](https://issues.apache.org/jira/browse/KAFKA-5443), which was initially analyzed in [#2053](#2053). A prior attempt to fix it was made in [#2057](#2057), but the fix was applied incorrectly and did not fully resolve the root cause. I’ve provided a more detailed explanation of the underlying issue and the reasoning behind this fix in [this comment](#3150 (comment)). --------- Signed-off-by: Sterligov Denis <[email protected]> Signed-off-by: Dominic Evans <[email protected]> Co-authored-by: Sterligov Denis <[email protected]> Co-authored-by: Dominic Evans <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2053
Sometimes in rare cases of corruption or other reason, Kafka can return batches with zero records even if a high watermark was not reached. In this case, sarama just tries to reread this batch again and again and is stuck. There is no resolution in this case except skipping this batch.
librdkafka can handle these cases skipping with a warning.