Skip to content

fix(consumer): call interceptors when MaxProcessingTime expire#1962

Merged
dnwe merged 1 commit intoIBM:masterfrom
hanxiaolin:fix-interceptor
Jun 22, 2021
Merged

fix(consumer): call interceptors when MaxProcessingTime expire#1962
dnwe merged 1 commit intoIBM:masterfrom
hanxiaolin:fix-interceptor

Conversation

@hanxiaolin
Copy link
Contributor

@hanxiaolin hanxiaolin commented Jun 7, 2021

Missing call for interception when MaxProcessingTime timed out and we process the remaining messages

@hanxiaolin hanxiaolin requested a review from bai as a code owner June 7, 2021 05:51
@ghost ghost added the cla-needed label Jun 7, 2021
@hanxiaolin
Copy link
Contributor Author

mod

@dnwe dnwe force-pushed the fix-interceptor branch from 01548a3 to 4c37463 Compare June 9, 2021 09:52
@ghost ghost removed the cla-needed label Jun 9, 2021
@dnwe dnwe requested a review from d1egoaz June 9, 2021 09:53
@dnwe
Copy link
Collaborator

dnwe commented Jun 22, 2021

@d1egoaz please could you take a look and confirm you're happy with the interceptor changes?

@d1egoaz
Copy link
Contributor

d1egoaz commented Jun 22, 2021

@d1egoaz please could you take a look and confirm you're happy with the interceptor changes?

@dnwe it looks it's doing the right think

for _, msg = range msgs[i:] {

apparently, something breaks the major loop and not all messages are being intercepted

https://github.com/Shopify/sarama/blob/7d06a470f1eeb5d51f48b9a69de7e02f778ecdd6/consumer.go#L470

I'm not too familiar with this block of code
https://github.com/Shopify/sarama/blob/7d06a470f1eeb5d51f48b9a69de7e02f778ecdd6/consumer.go#L474-L502

but thinks look ok to me

@dnwe dnwe changed the title fix: consumer interceptors fix(consumer): call interceptors when MaxProcessingTime expire Jun 22, 2021
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM too

@dnwe dnwe merged commit 0676fc2 into IBM:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants