Skip to content

Remove redundant switch-case, fix doc typos#1923

Merged
dnwe merged 5 commits intoIBM:masterfrom
bestgopher:master
Apr 29, 2021
Merged

Remove redundant switch-case, fix doc typos#1923
dnwe merged 5 commits intoIBM:masterfrom
bestgopher:master

Conversation

@bestgopher
Copy link
Contributor

The switch-case here is redundant. There is the logic of this part of the code in the decompress function.

@bestgopher bestgopher requested a review from bai as a code owner April 28, 2021 02:55
@ghost ghost added the cla-needed label Apr 28, 2021
@bestgopher
Copy link
Contributor Author

how to re-check CLA status?

@ghost ghost removed the cla-needed label Apr 28, 2021
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bestgopher
Copy link
Contributor Author

/test

@bai
Copy link
Contributor

bai commented Apr 28, 2021

Thanks for contributing!

@bestgopher
Copy link
Contributor Author

Thanks for contributing!

how to retest ci?

@bai bai requested a review from dnwe April 29, 2021 04:22
@bai bai changed the title remove redundant switch-case Remove redundant switch-case, fix doc typos Apr 29, 2021
@dnwe dnwe merged commit 0e2e2a4 into IBM:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants