Conversation
dnwe
reviewed
Apr 27, 2021
functional_test.go
Outdated
Comment on lines
122
to
125
| case "2.8.0": | ||
| confluentPlatformVersion = "6.0.1" | ||
| case "2.6.1": | ||
| case "2.7.1": | ||
| confluentPlatformVersion = "6.0.1" |
Collaborator
There was a problem hiding this comment.
You probably want to bump these confluentPlatformVersion values to 6.1.1 which is equivalent Apache Kafka 2.7.1 (there isn't a 2.8.0 equivalent available yet)
go.mod
Outdated
| github.com/golang/snappy v0.0.2 // indirect | ||
| github.com/jcmturner/gokrb5/v8 v8.4.2 | ||
| github.com/klauspost/compress v1.11.7 | ||
| github.com/klauspost/compress v1.12.2 |
Collaborator
There was a problem hiding this comment.
I'm not adverse to bumping go.mod under this PR, but it's probably worth noting that klauspost/compress has had some significant performance improvements between these two versions, so you might consider making this bump under a separate PR so that you can call it out in the next release notes
Contributor
Author
|
Thanks for your feedback - addressed your comments 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Kafka 2.8.0.