Skip to content

Fix: issues affecting code quality#1887

Merged
dnwe merged 7 commits intoIBM:masterfrom
withshubh:master
Mar 15, 2021
Merged

Fix: issues affecting code quality#1887
dnwe merged 7 commits intoIBM:masterfrom
withshubh:master

Conversation

@withshubh
Copy link
Contributor

Description

This PR fixes a few issues that were affecting the code quality.

Summary of changes

  • Merge variable declaration with assignment
  • Simplify switch cases with type assertion
  • Remove unnecessary wrapping of function call
  • Fix unnecessary typecasting on bytes.Buffer
  • Remove unnecessary guard around map
  • Fix check for empty string
  • Fix Yoda conditions

@withshubh withshubh requested a review from bai as a code owner February 18, 2021 14:47
@withshubh withshubh marked this pull request as draft February 18, 2021 15:37
@bai bai requested review from d1egoaz and dnwe February 19, 2021 05:47
@withshubh withshubh marked this pull request as ready for review February 22, 2021 09:05
Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these changes look reasonable to me

@dnwe dnwe merged commit f8d4ccd into IBM:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants